Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-2.6] 🐛: elbv2: wait for LB active state instead of resolving DNS name #5226

Open
wants to merge 1 commit into
base: release-2.6
Choose a base branch
from

Conversation

k8s-infra-cherrypick-robot

This is an automated cherry-pick of #5093

/assign nrb

Check for the LB "active" status instead of trying to resolve the DNS name to validate the LB is ready.

Using DNS name resolution as a way to check the load balancer is working
can cause problems that are dependent on the host running CAPA. In some
systems, the DNS resolution can fail with very large TTLs cached DNS
responses, causing very long provisioning times.

Instead of DNS resolution, let's use the AWS API to check for the load
balancer "active" state. Waiting for resolvable DNS names should be left
for the clients to do.
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 22, 2024
@k8s-ci-robot k8s-ci-robot requested review from damdo and faiq November 22, 2024 14:31
@k8s-ci-robot k8s-ci-robot added needs-priority size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 22, 2024
Copy link
Contributor

@AndiDog AndiDog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AndiDog

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 23, 2024
@damdo
Copy link
Member

damdo commented Nov 23, 2024

/test pull-cluster-api-provider-aws-e2e

@k8s-ci-robot
Copy link
Contributor

@damdo: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test pull-cluster-api-provider-aws-build
  • /test pull-cluster-api-provider-aws-build-docker
  • /test pull-cluster-api-provider-aws-build-docker-release-2-6
  • /test pull-cluster-api-provider-aws-build-release-2-6
  • /test pull-cluster-api-provider-aws-test-release-2-6
  • /test pull-cluster-api-provider-aws-verify-release-2-6

The following commands are available to trigger optional jobs:

  • /test pull-cluster-api-provider-aws-apidiff-release-2-6
  • /test pull-cluster-api-provider-aws-e2e-blocking-release-2-6
  • /test pull-cluster-api-provider-aws-e2e-conformance-release-2-6
  • /test pull-cluster-api-provider-aws-e2e-conformance-with-ci-artifacts-release-2-6
  • /test pull-cluster-api-provider-aws-e2e-eks-gc-release-2-6
  • /test pull-cluster-api-provider-aws-e2e-eks-release-2-6
  • /test pull-cluster-api-provider-aws-e2e-eks-testing-release-2-6
  • /test pull-cluster-api-provider-aws-e2e-release-2-6

Use /test all to run the following jobs that were automatically triggered:

  • pull-cluster-api-provider-aws-apidiff-release-2-6
  • pull-cluster-api-provider-aws-build
  • pull-cluster-api-provider-aws-build-docker
  • pull-cluster-api-provider-aws-build-docker-release-2-6
  • pull-cluster-api-provider-aws-build-release-2-6
  • pull-cluster-api-provider-aws-test-release-2-6
  • pull-cluster-api-provider-aws-verify-release-2-6

In response to this:

/test pull-cluster-api-provider-aws-e2e

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@r4f4
Copy link
Contributor

r4f4 commented Nov 25, 2024

/test pull-cluster-api-provider-aws-e2e-release-2-6

1 similar comment
@Ankitasw
Copy link
Member

/test pull-cluster-api-provider-aws-e2e-release-2-6

@k8s-ci-robot
Copy link
Contributor

@k8s-infra-cherrypick-robot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-provider-aws-e2e-release-2-6 a38f759 link false /test pull-cluster-api-provider-aws-e2e-release-2-6

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@r4f4
Copy link
Contributor

r4f4 commented Dec 5, 2024

STEP: Searching for AMI: name=capa-ami-ubuntu-18.04-v1.26.6* @ 11/26/24 12:50:42.09

@richardcase it seems the deprecated AMIs issue needs to be solved for other branches as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants