-
Notifications
You must be signed in to change notification settings - Fork 578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Remove placeholder CA bundle #5197
Conversation
The committers listed above are authorized under a signed CLA. |
Welcome @robinkb! |
Hi @robinkb. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test Thanks! I thought I had removed these, but apparently that commit got lost during some git shuffling. |
Hi @nrb, thanks for reviewing the PR! It looks like all the tests passed, so could you please add the |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: richardcase The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description shamelessly lifted from the equivalent PR on Cluster API.
What type of PR is this?
/kind bug
What this PR does / why we need it:
Starting with Kubernetes 1.31 it won't be possible anymore to continuously apply CRDs that are setting caBundle to an invalid value (in our case
Cg==
). The solution is to simply drop the caBundle field (it was never actually required by kube-apiserver).For more details see: https://kubernetes.slack.com/archives/C0EG7JC6T/p1722441161968339
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #5195
Special notes for your reviewer:
There are other references in the codebase to the string
Cg==
, but it appears to be for zeroing AWS credentials, not for setting the CA bundle.Checklist:
Release note: