Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ feat: Remove owned VPCEs when deleting VPC. #5193

Merged
merged 2 commits into from
Nov 12, 2024
Merged

✨ feat: Remove owned VPCEs when deleting VPC. #5193

merged 2 commits into from
Nov 12, 2024

Conversation

s3rj1k
Copy link
Contributor

@s3rj1k s3rj1k commented Oct 28, 2024 •
edited
Loading

/kind feature

Fixes #5192

Special notes for your reviewer:

Checklist:

  • squashed commits
  • includes documentation
  • includes emojis
  • adds unit tests
  • adds or updates e2e tests
NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 28, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @s3rj1k!

It looks like this is your first PR to kubernetes-sigs/cluster-api-provider-aws 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cluster-api-provider-aws has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 28, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @s3rj1k. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@s3rj1k s3rj1k changed the title Remove owned VPCEs when deleting VPC. ✨ feat: Remove owned VPCEs when deleting VPC. Oct 28, 2024
@richardcase
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 31, 2024
@s3rj1k s3rj1k force-pushed the eks-vpce-deletion branch from 379006c to b23c56c Compare October 31, 2024 15:03
@s3rj1k
Copy link
Contributor Author

s3rj1k commented Oct 31, 2024

Tests are green 🎉

@richardcase
Copy link
Member

/test ?

@k8s-ci-robot
Copy link
Contributor

@richardcase: The following commands are available to trigger required jobs:

  • /test pull-cluster-api-provider-aws-build
  • /test pull-cluster-api-provider-aws-build-docker
  • /test pull-cluster-api-provider-aws-test
  • /test pull-cluster-api-provider-aws-verify

The following commands are available to trigger optional jobs:

  • /test pull-cluster-api-provider-aws-apidiff-main
  • /test pull-cluster-api-provider-aws-e2e
  • /test pull-cluster-api-provider-aws-e2e-blocking
  • /test pull-cluster-api-provider-aws-e2e-clusterclass
  • /test pull-cluster-api-provider-aws-e2e-conformance
  • /test pull-cluster-api-provider-aws-e2e-conformance-with-ci-artifacts
  • /test pull-cluster-api-provider-aws-e2e-eks
  • /test pull-cluster-api-provider-aws-e2e-eks-gc
  • /test pull-cluster-api-provider-aws-e2e-eks-testing

Use /test all to run the following jobs that were automatically triggered:

  • pull-cluster-api-provider-aws-apidiff-main
  • pull-cluster-api-provider-aws-build
  • pull-cluster-api-provider-aws-build-docker
  • pull-cluster-api-provider-aws-test
  • pull-cluster-api-provider-aws-verify

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@richardcase
Copy link
Member

/test pull-cluster-api-provider-aws-e2e
/test pull-cluster-api-provider-aws-e2e-eks

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 31, 2024
@s3rj1k s3rj1k force-pushed the eks-vpce-deletion branch from 65e62c7 to b23c56c Compare October 31, 2024 23:35
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 31, 2024
@s3rj1k s3rj1k force-pushed the eks-vpce-deletion branch from 969db9a to 55c089c Compare November 1, 2024 01:46
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 1, 2024
@s3rj1k s3rj1k force-pushed the eks-vpce-deletion branch from 55c089c to b43ee71 Compare November 1, 2024 08:34
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 6, 2024
@s3rj1k s3rj1k force-pushed the eks-vpce-deletion branch 3 times, most recently from d34da13 to 6eb0e44 Compare November 6, 2024 23:17
@s3rj1k s3rj1k force-pushed the eks-vpce-deletion branch from 6eb0e44 to 0c80965 Compare November 8, 2024 10:24
@richardcase
Copy link
Member

/test pull-cluster-api-provider-aws-e2e-eks

@richardcase
Copy link
Member

A flake with the cloudformation creation, so:

/test pull-cluster-api-provider-aws-e2e

@s3rj1k
Copy link
Contributor Author

s3rj1k commented Nov 11, 2024 •
edited
Loading

due to "The security token included in the request is invalid."
(https://prow.k8s.io/view/gs/kubernetes-ci-logs/pr-logs/pull/kubernetes-sigs_cluster-api-provider-aws/5193/pull-cluster-api-provider-aws-e2e-eks/1854944144892366848)

/test pull-cluster-api-provider-aws-e2e

@s3rj1k
Copy link
Contributor Author

s3rj1k commented Nov 11, 2024

due to "Should've eventually succeeded creating an AWS CloudFormation stack"
/test pull-cluster-api-provider-aws-e2e

@s3rj1k
Copy link
Contributor Author

s3rj1k commented Nov 11, 2024

due to "The security token included in the request is invalid."

/test pull-cluster-api-provider-aws-e2e-eks

@s3rj1k
Copy link
Contributor Author

s3rj1k commented Nov 11, 2024

due to "Timed out after 2700.003s. Should've eventually succeeded creating an AWS CloudFormation stack"

/test pull-cluster-api-provider-aws-e2e-eks

@richardcase
Copy link
Member

due to "Timed out after 2700.003s. Should've eventually succeeded creating an AWS CloudFormation stack"

I've seen intermittent issue with the CF stack before, but looks like it's happening more often now. I think perhaps we need to log the AWS account where the failures are occurring, it could be with specific AWS accounts that boskos is handing to us. I will have a look in the morning. Thanks for persevering @s3rj1k .

@s3rj1k
Copy link
Contributor Author

s3rj1k commented Nov 11, 2024

One out of 1 tests failed with "Timed out after 1800.000s.
Eventually failed waiting for EKS addon "coredns" to have status ["ACTIVE" "DEGRADED"] for EKS cluster"

/test pull-cluster-api-provider-aws-e2e-eks

@richardcase
Copy link
Member

@s3rj1k - they passed :)

@richardcase
Copy link
Member

Capturing that the e2e passed for both EKS and non-EKS:

@richardcase
Copy link
Member

From my side:

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: richardcase

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 12, 2024
@richardcase
Copy link
Member

For lgtm:

/assign @AndiDog
/assign @nrb
/assign @dlipovetsky
/assign @damdo

@s3rj1k
Copy link
Contributor Author

s3rj1k commented Nov 12, 2024

@richardcase Brute-forced e2e into passing :)

damdo
damdo reviewed Nov 12, 2024
View reviewed changes
Copy link
Member

@damdo damdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 12, 2024
@k8s-ci-robot k8s-ci-robot merged commit df09e6c into kubernetes-sigs:main Nov 12, 2024
21 checks passed
@damdo damdo mentioned this pull request Nov 12, 2024
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damdo damdo damdo left review comments

@richardcase richardcase richardcase left review comments

@dlipovetsky dlipovetsky Awaiting requested review from dlipovetsky

Assignees

@nrb nrb

@AndiDog AndiDog

@dlipovetsky dlipovetsky

@damdo damdo

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove all owned VPCEs during VPC deletion
7 participants
@s3rj1k @k8s-ci-robot @richardcase @damdo @nrb @AndiDog @dlipovetsky