✨ feat: graduate the garbage collection feature #4957
Conversation
k8s-ci-robot
added
kind/feature
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
cncf-cla: yes
|
/test ? |
|
@richardcase: The following commands are available to trigger required jobs:
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test pull-cluster-api-provider-aws-e2e |
|
/test pull-cluster-api-provider-aws-test |
This moves the "garbage collection" feature out of experimental and to be enabled by default. Signed-off-by: Richard Case <[email protected]>
richardcase
force-pushed
the
graduate_gc
branch
from
03de6e2 to
3f0faf4
Compare
|
/test pull-cluster-api-provider-aws-e2e |
|
Can we link the documentation in the release note? |
| > Note: if you enable this feature **ALL** clusters will be marked as requiring garbage collection. | ||
| ## Enabling Alternative Strategy | ||
|
|
||
| The default strategy is to use the AWS resource tagging API. This may not be suitable in all cases and so an alternative strategy can be enabled. The alternative strategy is usually needed in a airgapped environment where the resource tagging API is not available. |
There was a problem hiding this comment.
Can we describe here what the alternative strategy does?
|
/test pull-cluster-api-provider-aws-e2e |
|
@richardcase: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
I need to pick this up again. /milestone v2.7.0 |
|
Hey @richardcase are you likely to pick it up in the coming days? Or should we take it out of v2.7.0? |
Not likely i the coming days i'm afraid. To much still outstanding with the AMI stuff. Yes lets move to v2.8.0 /milestone v2.8.0 |
k8s-ci-robot
added
the
needs-rebase
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
I'm going to re-create this: /close |
|
@richardcase: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What type of PR is this?
/kind feature
What this PR does / why we need it:
This moves the "garbage collection" feature out of experimental & to beta and as such it will be enabled by default. The doesn't move the alternative strategy out of alpha as we don't have enough testing to cover it.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #4397
Special notes for your reviewer:
Checklist:
Release note: