✨ feat: create vpc objects in explicitly provided availability zones

[synthe102]

What type of PR is this?

/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #4333, continues the work started by @Skarlso in this PR by:

• moving the defaults for AvailabilityZoneSelection and AvailabilityZoneUsageLimit into defaulting webhooks instead of CRDs
• adding check in validating webhooks for conflicting use of AvailabilityZoneUsageLimit and AvailabilityZoneSelection with AvailabilityZones

Special notes for your reviewer:

Checklist:

• squashed commits
• includes documentation
• includes emojis
• adds unit tests
• adds or updates e2e tests

Release note:

Ability to specify Availability Zones from spec.network.vpc in AWSManagedControlPlane, AWSCluster and AWSClusterTemplate CRDs.

[k8s-ci-robot]

Hi @synthe102. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[AndiDog]

/ok-to-test

[AndiDog]

Please change the release note to something that's readable by users (.spec.vpc) instead of developers (VPCSpec), and best use a verb to describe the change.

[synthe102]

/test pull-cluster-api-provider-aws-verify

[AndiDog]

I have a few minor suggestions that can mostly be included directly. Looks good overall. Only a rebase is needed after those changes, so the PR is mergeable (you may just have some conflicts that go away with git rebase origin/main && make generate).

[synthe102]

@AndiDog Thanks for the review !
PR is rebased and I added your suggestions.

[AndiDog]

/lgtm

[cpwc]

Hi @AndiDog anyone can take a look at this PR? Looking for another /approve.

[cpwc]

Hi @AndiDog giving this a bump if anyone can take a look at this PR? Looking for another /approve.

[AndiDog]

Can you rebase this PR? We should then try to get a separate review and /approve quickly before running into conflicts again.

[k8s-ci-robot]

@synthe102: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-cluster-api-provider-aws-build-release-2-6	f0fbb06	link	true	/test pull-cluster-api-provider-aws-build-release-2-6
pull-cluster-api-provider-aws-build-docker-release-2-6	f0fbb06	link	true	/test pull-cluster-api-provider-aws-build-docker-release-2-6

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[k8s-ci-robot]

New changes are detected. LGTM label has been removed.

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: synthe102 / name: Léonard Suslian (0e0c521)

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from andidog. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[synthe102]

@AndiDog the PR has been rebased, hope we'll get a last review 🙏