🌱 Backport main to 2.4 #4878
Merged
🌱 Backport main to 2.4 #4878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Andreas Sommer <[email protected]>
- add Taints field - add TuningConfigs field
This is required for when the managment cluster has OwnerReferencesPermissionEnforcement admission controller enabled.
`us-east-1` is invalid as a Location Contraint when creating a bucket. "Buckets in Region us-east-1 have a LocationConstraint of null."[1] [1] https://docs.aws.amazon.com/AmazonS3/latest/API/API_GetBucketLocation.html#API_GetBucketLocation_ResponseSyntax
…loc-use1 🐛 fix: s3 bucket in us-east-1 should not set location constraint
Signed-off-by: Richard Case <[email protected]>
- cleanup *types.go - report erros in conditions
…chinepool ✨ ROSA: Reconcile ROSAMachinePool fields
Bumps the dependencies group in /hack/tools with 2 updates: [github.com/mikefarah/yq/v4](https://github.com/mikefarah/yq) and [sigs.k8s.io/kind](https://github.com/kubernetes-sigs/kind). Updates `github.com/mikefarah/yq/v4` from 4.40.5 to 4.42.1 - [Release notes](https://github.com/mikefarah/yq/releases) - [Changelog](https://github.com/mikefarah/yq/blob/master/release_notes.txt) - [Commits](mikefarah/yq@v4.40.5...v4.42.1) Updates `sigs.k8s.io/kind` from 0.21.0 to 0.22.0 - [Release notes](https://github.com/kubernetes-sigs/kind/releases) - [Commits](kubernetes-sigs/kind@v0.21.0...v0.22.0) --- updated-dependencies: - dependency-name: github.com/mikefarah/yq/v4 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: dependencies - dependency-name: sigs.k8s.io/kind dependency-type: direct:production update-type: version-update:semver-minor dependency-group: dependencies ... Signed-off-by: dependabot[bot] <[email protected]>
- sync replicase to CAPI MachinePool when autoscaling is enabled - fixed ROSAMachinePool not reporting ready when autoscaling enabled
…derid-list ✨ ROSA: Reconcile ROSAMachinePool.spec.ProviderIDList
🌱 [PROPOSAL] Add damdo as a reviewer
✨ ROSA: Add additionalSecurityGroups field to ROSAMachinePool
Signed-off-by: Vince Prignano <[email protected]>
🌱 Align golangci-lint with upstream Cluster API
…ot/go_modules/hack/tools/dependencies-a89a6c7354 🌱 Bump the dependencies group in /hack/tools with 2 updates
🌱 Update awsmachinetemplate_webhook.go, fix typo
Signed-off-by: Xiangjing Li <[email protected]>
- remove cluster expirationTime
…new-fields ✨Add new fields to ROSAControlPlane - additionalTags, etcdEncryption, endpointAccess
From Ignition v3.1 there is support in the struct to setup a proxy, and CA validation. This changeset allows AWSMachines to expose these features when using Ignition. Signed-off-by: Vince Prignano <[email protected]>
…ition 🌱 Add support for Ignition v3 Proxy and TLS
- group rosa clusterCompute config - make force deletion optional through annotation - report deleting status in condition
- fixed machinepool triggering an upgrade when upgrading controlPlane
✨ ROSA: Cleanup
✨ ROSA: Support audit log forwarding
Signed-off-by: melserngawy <[email protected]>
✨ Add nodeDrainGracePeriod for RosaMachinePool
- use the correct typemetav1.Duration for NodeDrainGracePeriod field - fixed reconcileProviderIDList() listing terminated/stopped instances
…tags ✨ ROSA: Add additionalTags API field to ROSAMachinePool
…-shardid ✨ ROSA: Add ProvisionShardID API field to ROSAControlPlane
k8s-ci-robot
added
kind/support
|
Adding label Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
size/XXL
k8s-ci-robot
added
release-note-none
|
/hold This is mostly to double check the contents before I manually fast forward the |
k8s-ci-robot
added
the
do-not-merge/hold
|
Will also wait to include #4877 |
|
Manually pushed the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind support
What this PR does / why we need it:
Backporting fixes from main to release-2.4.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Checklist:
Release note: