Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ ROSA: support long cluster name #4851

Merged
merged 1 commit into from
Mar 7, 2024
Merged

✨ ROSA: support long cluster name #4851

merged 1 commit into from
Mar 7, 2024

Conversation

serngawy
Copy link
Contributor

@serngawy serngawy commented Mar 6, 2024

What type of PR is this?
/kind feature

What this PR does / why we need it:
It allow long cluster name and domain prefix

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Checklist:

  • [ X] squashed commits
  • includes documentation
  • includes emojis
  • adds unit tests
  • adds or updates e2e tests

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 6, 2024
@k8s-ci-robot k8s-ci-robot requested review from AndiDog and faiq March 6, 2024 17:32
@k8s-ci-robot k8s-ci-robot added needs-priority needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 6, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @serngawy. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 6, 2024
@serngawy
Copy link
Contributor Author

serngawy commented Mar 6, 2024

/cc @muraee

@k8s-ci-robot k8s-ci-robot requested a review from muraee March 6, 2024 18:45
@Ankitasw
Copy link
Member

Ankitasw commented Mar 7, 2024

@serngawy there was a customer issue due to which this cluster name length was kept as limited, so I dont think its wise to increase it to so many characters.

@serngawy
Copy link
Contributor Author

serngawy commented Mar 7, 2024

@serngawy there was a customer issue due to which this cluster name length was kept as limited, so I dont think its wise to increase it to so many characters.

@Ankitasw Its a user requirement and it has been tested successfully.

@k8s-ci-robot k8s-ci-robot changed the title ✨ Add long cluster name ROSA: support long cluster name Mar 7, 2024
@muraee
Copy link
Contributor

muraee commented Mar 7, 2024

/retitle ✨ ROSA: support long cluster name

@k8s-ci-robot k8s-ci-robot changed the title ROSA: support long cluster name ✨ ROSA: support long cluster name Mar 7, 2024
muraee
muraee reviewed Mar 7, 2024
View reviewed changes
controlplane/rosa/api/v1beta2/rosacontrolplane_types.go Outdated
// +kubebuilder:validation:MaxLength:=15
// +kubebuilder:validation:Pattern:=`^[a-z]([-a-z0-9]*[a-z0-9])?$`
// +optional
DomainPrefix string `json:"domainPrefix"`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we have a more descriptive comment here of what this field does instead.
DomainPrefix is an optional unique domain prefix of the cluster. This will be used when generating a sub-domain for your cluster on openshiftapps.com

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update it

muraee
muraee reviewed Mar 7, 2024
View reviewed changes
controlplane/rosa/api/v1beta2/rosacontrolplane_types.go Outdated
// +kubebuilder:validation:MaxLength:=15
// +kubebuilder:validation:Pattern:=`^[a-z]([-a-z0-9]*[a-z0-9])?$`
// +optional
DomainPrefix string `json:"domainPrefix"`
Copy link
Contributor

@muraee muraee Mar 7, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
DomainPrefix string `json:"domainPrefix"`
DomainPrefix string `json:"domainPrefix,omitempty"`

optional fields need omitempty

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ops, add it

@muraee
Copy link
Contributor

muraee commented Mar 7, 2024

/lgtm
cc @vincepri

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 7, 2024
vincepri
vincepri reviewed Mar 7, 2024
View reviewed changes
controlplane/rosa/api/v1beta2/rosacontrolplane_types.go Outdated
RosaClusterName string `json:"rosaClusterName"`

// DomainPrefix is an optional unique domain prefix addedd to the cluster domain name. It will be used
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// DomainPrefix is an optional unique domain prefix addedd to the cluster domain name. It will be used
// DomainPrefix is an optional prefix added to the cluster's domain name. It will be used

@serngawy
Add long cluster name
b173354 
Signed-off-by: melserngawy <[email protected]>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 7, 2024
@vincepri
Copy link
Member

vincepri commented Mar 7, 2024

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 7, 2024
vincepri
vincepri approved these changes Mar 7, 2024
View reviewed changes
Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 7, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 7, 2024
@k8s-ci-robot k8s-ci-robot merged commit 5aa9d22 into kubernetes-sigs:main Mar 7, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@muraee muraee muraee left review comments

@vincepri vincepri vincepri approved these changes

@AndiDog AndiDog Awaiting requested review from AndiDog

@faiq faiq Awaiting requested review from faiq

Assignees

@vincepri vincepri

@muraee muraee

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@serngawy @k8s-ci-robot @Ankitasw @muraee @vincepri