Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Align golangci-lint with upstream Cluster API #4847

Merged
merged 1 commit into from
Mar 6, 2024
Merged

🌱 Align golangci-lint with upstream Cluster API #4847

merged 1 commit into from
Mar 6, 2024

Conversation

vincepri
Copy link
Member

@vincepri vincepri commented Mar 4, 2024

What type of PR is this?

What this PR does / why we need it:

This PR adds a golangci-lint GitHub action, which gives inline feedback on the PR, and aligns the linter with upstream cluster-api.

/kind cleanup

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Checklist:

  • squashed commits
  • includes documentation
  • includes emojis
  • adds unit tests
  • adds or updates e2e tests

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 4, 2024
@vincepri
Copy link
Member Author

vincepri commented Mar 4, 2024

/assign @nrb

@k8s-ci-robot k8s-ci-robot requested review from fiunchinho and nrb March 4, 2024 20:30
@vincepri
Copy link
Member Author

vincepri commented Mar 4, 2024

/assign @damdo

nrb
nrb approved these changes Mar 5, 2024
View reviewed changes
Copy link
Contributor

@nrb nrb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 5, 2024
@vincepri
Copy link
Member Author

vincepri commented Mar 5, 2024

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 5, 2024
@vincepri
Copy link
Member Author

vincepri commented Mar 5, 2024

/hold

for @richardcase

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 5, 2024
@damdo
Copy link
Member

damdo commented Mar 5, 2024 •
edited
Loading

Nice one!
/lgtm
Thank you

Since we are touching a lot of code, even if it is an innocent refactor, let's give the E2Es a spin.

/test pull-cluster-api-provider-aws-e2e
/test pull-cluster-api-provider-aws-e2e-eks

@vincepri
Copy link
Member Author

vincepri commented Mar 5, 2024

/test pull-cluster-api-provider-aws-e2e-eks

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 5, 2024
@vincepri
Copy link
Member Author

vincepri commented Mar 5, 2024

/test pull-cluster-api-provider-aws-e2e
/test pull-cluster-api-provider-aws-e2e-eks

@vincepri
Copy link
Member Author

vincepri commented Mar 5, 2024

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 5, 2024
@damdo
Copy link
Member

damdo commented Mar 5, 2024 •
edited
Loading

Looks like E2Es timed out.
I've seen those timeouts in other PRs we should probably look into them, there might be a flake somewhere (unrelated to this PR)

/test pull-cluster-api-provider-aws-e2e

@vincepri
Copy link
Member Author

vincepri commented Mar 5, 2024

/retest

1 similar comment
@vincepri
Copy link
Member Author

vincepri commented Mar 6, 2024

/retest

@Ankitasw
Copy link
Member

Ankitasw commented Mar 6, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 6, 2024
@k8s-ci-robot k8s-ci-robot merged commit 8f94aab into kubernetes-sigs:main Mar 6, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nrb nrb nrb approved these changes

@fiunchinho fiunchinho Awaiting requested review from fiunchinho

Assignees

@nrb nrb

@damdo damdo

@Ankitasw Ankitasw

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vincepri @k8s-ci-robot @damdo @Ankitasw @nrb