🐛 Allow overriding health check endpoint protocol #4846

mtulio · 2024-03-04T19:36:03Z

What type of PR is this?

/kind bug

What this PR does / why we need it:

This change intents to synchronize w/ CLB the health check attributes for
API LB, and use the correct health check path when using HTTP or HTTPS.

The following target group health check attributes for ELBv2
are setting based in the CLB configuration for all protocols:

interval: current(30) want(10)
timeout: current(10) want(5)
health threshold count: current(5) want(5)
unhealthy threshold count: current(2) want(3)

When using HTTP or HTTPS, the following attributes will be fixed:

path: current("/") want("/readyz")

*'current' is the default values set by AWS, 'want' is the value set
in the CLB.

Which issue(s) this PR fixes
N/A

Special notes for your reviewer:

Checklist:

Release note:

Fixes in the health check probe configuration for API target group on ELBv2. The correct health check path now is set to `/readyz` when `AWSLoadBalancerSpec.HealthCheckProtocol` is `HTTP` or `HTTPS`.

k8s-ci-robot · 2024-03-04T19:36:12Z

Hi @mtulio. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

api/v1beta2/network_types.go

mtulio · 2024-03-04T21:32:13Z

Holding while more tests is done.

/hold

pkg/cloud/services/elb/loadbalancer.go

faiq · 2024-03-14T05:20:44Z

/lgtm

api/v1beta2/network_types.go

faiq · 2024-03-14T20:56:05Z

/hold

is there an API change?

This change intents to synchronize w/ CLB the health check attributes for API LB, and use the correct health check path when using HTTP or HTTPS. The following target group health check attributes for ELBv2 are setting based in the CLB configuration for all protocols: - interval: current(30) want(10) - timeout: current(10) want(5) - health threshold count: current(5) want(5) - unhealthy threshold count: current(2) want(3) When using HTTP or HTTPS, the following attributes will be fixed: - path: current("/") want("/readyz") *'current' is the default values set by AWS, 'want' is the value set in the CLB.

faiq · 2024-03-15T02:12:17Z

/test pull-cluster-api-provider-aws-test

faiq · 2024-03-15T02:55:26Z

/retest

mtulio · 2024-03-15T11:55:49Z

/retest

@faiq three[1] unit were failing, just fixed it adding the Unhealthy threshold to the mock &elbv2.CreateTargetGroupInput

[1]
"main create flow"
"created with ipv6 vpc"
"load balancer is not an NLB scope security groups will be added"

faiq · 2024-03-15T14:53:56Z

/lgtm

faiq · 2024-03-15T14:54:21Z

/unhold

mtulio · 2024-03-15T20:00:04Z

PTAL @nrb ? cc @vincepri

faiq · 2024-03-18T15:15:33Z

/approve

vincepri

/approve

vincepri · 2024-03-18T15:22:28Z

/approve

k8s-ci-robot · 2024-03-18T15:22:36Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: faiq, vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [vincepri]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

vincepri · 2024-03-18T15:23:43Z

/hold

@mtulio mind renaming the PR title with a more descriptive one?

nrb · 2024-03-18T15:31:15Z

/retitle 🐛 Allow overriding health check endpoint protocol
/unhold

k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 4, 2024

k8s-ci-robot requested review from AndiDog and faiq March 4, 2024 19:36

mtulio force-pushed the CORS-3289-lb-fix-api-hc branch from f593e63 to 8f48a0f Compare March 4, 2024 20:25

k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 4, 2024

mtulio force-pushed the CORS-3289-lb-fix-api-hc branch 5 times, most recently from f98eed3 to 3c2778e Compare March 4, 2024 20:44

mtulio changed the title ~~🐛 fix: Control plane NLB health check when using the protocol HTTP or HTTPS~~ 🐛 fix: Fixes in the health check probe configuration for API target group on ELBv2 Mar 4, 2024

mtulio changed the title ~~🐛 fix: Fixes in the health check probe configuration for API target group on ELBv2~~ 🐛 fix: Fixes in the health check probe config for ELBv2 of API Mar 4, 2024

faiq reviewed Mar 4, 2024

View reviewed changes

api/v1beta2/network_types.go Outdated Show resolved Hide resolved

mtulio force-pushed the CORS-3289-lb-fix-api-hc branch from 3c2778e to 671405e Compare March 4, 2024 21:20

mtulio marked this pull request as ready for review March 4, 2024 21:20

k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 4, 2024

k8s-ci-robot requested a review from richardcase March 4, 2024 21:20

k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 4, 2024

faiq reviewed Mar 5, 2024

View reviewed changes

pkg/cloud/services/elb/loadbalancer.go Show resolved Hide resolved

mtulio changed the title ~~🐛 fix: Fixes in the health check probe config for ELBv2 of API~~ 🐛 Fixes in the health check probe config for ELBv2 of API Mar 5, 2024

mtulio force-pushed the CORS-3289-lb-fix-api-hc branch from 671405e to 71d34b3 Compare March 5, 2024 18:21

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 14, 2024

faiq reviewed Mar 14, 2024

View reviewed changes

api/v1beta2/network_types.go Outdated Show resolved Hide resolved

k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 14, 2024

mtulio force-pushed the CORS-3289-lb-fix-api-hc branch from eeaad63 to 7a658ca Compare March 15, 2024 01:49

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 15, 2024

🐛 fix: unit tests for ELBv2 health check HTTP and HTTPS

d48958c

mtulio force-pushed the CORS-3289-lb-fix-api-hc branch from 7a658ca to d48958c Compare March 15, 2024 11:54

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 15, 2024

k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 15, 2024

vincepri approved these changes Mar 18, 2024

View reviewed changes

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 18, 2024

k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 18, 2024

k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 18, 2024

k8s-ci-robot changed the title ~~🐛 Fixes in the health check probe config for ELBv2 of API~~ 🐛 Allow overriding health check endpoint protocol Mar 18, 2024

k8s-ci-robot merged commit cbf5317 into kubernetes-sigs:main Mar 18, 2024
23 checks passed

mtulio deleted the CORS-3289-lb-fix-api-hc branch March 18, 2024 16:53

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🐛 Allow overriding health check endpoint protocol #4846

🐛 Allow overriding health check endpoint protocol #4846

mtulio commented Mar 4, 2024 •

edited

Loading

k8s-ci-robot commented Mar 4, 2024

mtulio commented Mar 4, 2024

faiq commented Mar 14, 2024

faiq commented Mar 14, 2024

faiq commented Mar 15, 2024

faiq commented Mar 15, 2024

mtulio commented Mar 15, 2024 •

edited

Loading

faiq commented Mar 15, 2024

faiq commented Mar 15, 2024

mtulio commented Mar 15, 2024

faiq commented Mar 18, 2024

vincepri left a comment •

edited

Loading

vincepri commented Mar 18, 2024

k8s-ci-robot commented Mar 18, 2024

vincepri commented Mar 18, 2024

nrb commented Mar 18, 2024

🐛 Allow overriding health check endpoint protocol #4846

🐛 Allow overriding health check endpoint protocol #4846

Conversation

mtulio commented Mar 4, 2024 • edited Loading

k8s-ci-robot commented Mar 4, 2024

mtulio commented Mar 4, 2024

faiq commented Mar 14, 2024

faiq commented Mar 14, 2024

faiq commented Mar 15, 2024

faiq commented Mar 15, 2024

mtulio commented Mar 15, 2024 • edited Loading

faiq commented Mar 15, 2024

faiq commented Mar 15, 2024

mtulio commented Mar 15, 2024

faiq commented Mar 18, 2024

vincepri left a comment • edited Loading

Choose a reason for hiding this comment

vincepri commented Mar 18, 2024

k8s-ci-robot commented Mar 18, 2024

vincepri commented Mar 18, 2024

nrb commented Mar 18, 2024

mtulio commented Mar 4, 2024 •

edited

Loading

mtulio commented Mar 15, 2024 •

edited

Loading

vincepri left a comment •

edited

Loading