Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 [PROPOSAL] Add damdo as a reviewer #4842

Merged
merged 1 commit into from
Mar 4, 2024

Conversation

richardcase
Copy link
Member

@richardcase richardcase commented Mar 1, 2024

What type of PR is this?

/kind support

What this PR does / why we need it:

This is to propose that we add @damdo as a reviewer. He has contributed a lot to CAPA and has recently been spending a lot of time shadowing releases as well.

I propose we leave this open until the next office hours (4th March) and then merge if there are no objections.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

/cc @dlipovetsky @Ankitasw @vincepri

Checklist:

  • squashed commits
  • includes documentation
  • includes emojis
  • adds unit tests
  • adds or updates e2e tests

Release note:

Add @damdo as a reviewer

Signed-off-by: Richard Case <[email protected]>
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/support Categorizes issue or PR as a support question. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 1, 2024
@k8s-ci-robot k8s-ci-robot requested a review from Ankitasw March 1, 2024 15:13
@k8s-ci-robot k8s-ci-robot requested a review from dlipovetsky March 1, 2024 15:13
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 1, 2024
@richardcase richardcase changed the title [PROPOSAL] Add damdo as a reviewer 🌱 [PROPOSAL] Add damdo as a reviewer Mar 1, 2024
@nrb
Copy link
Contributor

nrb commented Mar 1, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 1, 2024
@vincepri
Copy link
Member

vincepri commented Mar 1, 2024

/approve

/hold
until next week's meeting

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 1, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 1, 2024
@dlipovetsky
Copy link
Contributor

/lgtm

+1 Thanks for your contributions so far @damdo!

@dlipovetsky
Copy link
Contributor

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 4, 2024
@k8s-ci-robot k8s-ci-robot merged commit 2d004cc into kubernetes-sigs:main Mar 4, 2024
26 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/support Categorizes issue or PR as a support question. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants