Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Revert "Supporting externally managed Control Plane" #4821

Closed
wants to merge 1 commit into from

Conversation

nrb
Copy link
Contributor

@nrb nrb commented Feb 26, 2024

This reverts commit 6193d17, reversing changes made to 6ffb575.

What type of PR is this?

/kind regression

What this PR does / why we need it:

These changes are causing a panic when the controlPlaneRef is nil.

Reverts #4438 (cc @prometherion)

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #4818

Special notes for your reviewer:

Checklist:

  • squashed commits
  • includes emojis

Release note:

NONE

…ues/4437"

This reverts commit 6193d17, reversing
changes made to 6ffb575.
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/regression Categorizes issue or PR as related to a regression from a prior release. labels Feb 26, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign sbueringer for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 26, 2024
@vincepri
Copy link
Member

/lgtm
/assign @richardcase

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 26, 2024
@nrb
Copy link
Contributor Author

nrb commented Feb 26, 2024

/retitle 🐛 Revert "Supporting externally managed Control Plane"

@k8s-ci-robot k8s-ci-robot changed the title 🐛 Revert "Merge pull request #4438 from prometherion/issues/4437" 🐛 Revert "Supporting externally managed Control Plane" Feb 26, 2024
@prometherion
Copy link
Contributor

@nrb there's a proposed fix with #4817, reverting this commit would ruin my efforts in supporting this feature.

Asking to get this in hold @vincepri

@nrb
Copy link
Contributor Author

nrb commented Feb 26, 2024

@prometherion I think that's fair.

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 26, 2024
@nrb
Copy link
Contributor Author

nrb commented Feb 27, 2024

I'm going to close this in favor of #4817 or #4822, since according to slack conversations, other projects rely on this PR. Plus, it's been in flight for quite a while and we should fix forward.

Thank you for your contributions @prometherion and apologies for confusion.

@nrb nrb closed this Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/regression Categorizes issue or PR as related to a regression from a prior release. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Panic when controlPlaneRef is nil
5 participants