-
Notifications
You must be signed in to change notification settings - Fork 578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Revert "Supporting externally managed Control Plane" #4821
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
/retitle 🐛 Revert "Supporting externally managed Control Plane" |
@prometherion I think that's fair. /hold |
I'm going to close this in favor of #4817 or #4822, since according to slack conversations, other projects rely on this PR. Plus, it's been in flight for quite a while and we should fix forward. Thank you for your contributions @prometherion and apologies for confusion. |
This reverts commit 6193d17, reversing changes made to 6ffb575.
What type of PR is this?
/kind regression
What this PR does / why we need it:
These changes are causing a panic when the
controlPlaneRef
is nil.Reverts #4438 (cc @prometherion)
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #4818
Special notes for your reviewer:
Checklist:
Release note: