Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨Add missing Fields to RosaControlPlane - tags, etcdEncryption #4795

Closed

Conversation

xiangjingli
Copy link
Contributor

@xiangjingli xiangjingli commented Feb 16, 2024

What type of PR is this?
/kind feature

What this PR does / why we need it:
Adding the missing RosaControlPlan API fields;
Tags,
EtcdEncryption,
EtcdEncryptionKMSArn

Also removing the accountID and creatorARN from ROSA cluster templates as it is not necessary to declare them explicitly in the rosaControlPlane spec along the recent change.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
#4737

Special notes for your reviewer:

There is another PR for adding different fields to RosaControlplan delivered by @serngawy
#4780

I will rebase the PR after the 4780 PR is merged.

Checklist:

  • squashed commits
  • includes documentation
  • includes emojis
  • adds unit tests
  • adds or updates e2e tests

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Feb 16, 2024
Copy link

linux-foundation-easycla bot commented Feb 16, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: xiangjingli / name: Xiangjing Li (76332edd0f2082358bdf7c1243b9ea749dba3dc6)

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. needs-priority labels Feb 16, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @xiangjingli!

It looks like this is your first PR to kubernetes-sigs/cluster-api-provider-aws 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cluster-api-provider-aws has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 16, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @xiangjingli. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Feb 16, 2024
@xiangjingli
Copy link
Contributor Author

/cc @stevekuznetsov
/cc @muraee
/cc @serngawy

@k8s-ci-robot
Copy link
Contributor

@xiangjingli: GitHub didn't allow me to request PR reviews from the following users: serngawy.

Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @stevekuznetsov
/cc @muraee
/cc @serngawy

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Feb 16, 2024
@xiangjingli xiangjingli changed the title Add missing Fields to RosaControlPlane - tags, etcdEncryption ✨ Add missing Fields to RosaControlPlane - tags, etcdEncryption Feb 16, 2024
@xiangjingli xiangjingli changed the title ✨ Add missing Fields to RosaControlPlane - tags, etcdEncryption ✨Add missing Fields to RosaControlPlane - tags, etcdEncryption Feb 16, 2024
@xiangjingli xiangjingli force-pushed the newROSAControlPlaneSpec branch 2 times, most recently from 59c3eea to 76332ed Compare February 20, 2024 17:10
@xiangjingli xiangjingli force-pushed the newROSAControlPlaneSpec branch from 76332ed to 66bb485 Compare February 20, 2024 17:49
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 20, 2024
@xiangjingli xiangjingli deleted the newROSAControlPlaneSpec branch February 20, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-priority release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants