Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ rosa: use the openshift/rosa libraries where we can #4765

Merged
merged 3 commits into from
Feb 27, 2024
Merged

✨ rosa: use the openshift/rosa libraries where we can #4765

merged 3 commits into from
Feb 27, 2024

Conversation

stevekuznetsov
Copy link
Contributor

@stevekuznetsov stevekuznetsov commented Jan 31, 2024 •
edited
Loading

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jan 31, 2024
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jan 31, 2024
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 12, 2024
@stevekuznetsov stevekuznetsov force-pushed the skuznets/use-rosa-library branch from 6e8e065 to a60c972 Compare February 13, 2024 15:53
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 13, 2024
@stevekuznetsov
Copy link
Contributor Author

Requires openshift/rosa#1782

@stevekuznetsov stevekuznetsov force-pushed the skuznets/use-rosa-library branch 2 times, most recently from b9e7065 to 75dbe7a Compare February 13, 2024 16:24
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Feb 13, 2024
@stevekuznetsov stevekuznetsov force-pushed the skuznets/use-rosa-library branch 2 times, most recently from 375339e to b4b53eb Compare February 13, 2024 16:31
@stevekuznetsov stevekuznetsov changed the title WIP: rosa: use the openshift/rosa libraries where we can rosa: use the openshift/rosa libraries where we can Feb 13, 2024
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 13, 2024
@stevekuznetsov stevekuznetsov changed the title rosa: use the openshift/rosa libraries where we can ✨ rosa: use the openshift/rosa libraries where we can Feb 13, 2024
@stevekuznetsov stevekuznetsov force-pushed the skuznets/use-rosa-library branch from b4b53eb to 3cb8fe9 Compare February 13, 2024 16:51
vincepri
vincepri approved these changes Feb 13, 2024
View reviewed changes
Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/assign @muraee

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 13, 2024
@stevekuznetsov stevekuznetsov force-pushed the skuznets/use-rosa-library branch 2 times, most recently from 3463264 to ac2dd6a Compare February 14, 2024 17:40
@stevekuznetsov
Copy link
Contributor Author

/test pull-cluster-api-provider-aws-test

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 20, 2024
@stevekuznetsov stevekuznetsov force-pushed the skuznets/use-rosa-library branch from ac2dd6a to 6dea50a Compare February 20, 2024 22:05
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 20, 2024
@stevekuznetsov
Copy link
Contributor Author

Now depends on openshift/rosa#1792

@stevekuznetsov stevekuznetsov force-pushed the skuznets/use-rosa-library branch from 6dea50a to bcfe755 Compare February 21, 2024 13:54
@stevekuznetsov stevekuznetsov mentioned this pull request Feb 21, 2024
Merged
5 tasks
@stevekuznetsov stevekuznetsov force-pushed the skuznets/use-rosa-library branch from bcfe755 to 7889adf Compare February 22, 2024 14:30
@stevekuznetsov
rosa: use the openshift/rosa libraries where we can
c1975bb 
Signed-off-by: Steve Kuznetsov <[email protected]>
@stevekuznetsov
rosa: use CEL validation for versions
ddc3065 
The webhooks we had were only giving us a nice error message on top of
the parsing validation, and we can get all of that benefit by just using
a CEL matcher and a custom error message. Not having to deploy and run
webhooks simplifies things for us a sizeable amount and makes local
testing much easier, as well.

Signed-off-by: Steve Kuznetsov <[email protected]>
@stevekuznetsov
rosacontrolplane: support a separate billing account
bf714d8 
Signed-off-by: Steve Kuznetsov <[email protected]>
@stevekuznetsov stevekuznetsov force-pushed the skuznets/use-rosa-library branch from 7889adf to bf714d8 Compare February 27, 2024 02:24
@muraee
Copy link
Contributor

muraee commented Feb 27, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 27, 2024
@k8s-ci-robot k8s-ci-robot merged commit 0b59c11 into kubernetes-sigs:main Feb 27, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@muraee muraee muraee left review comments

@vincepri vincepri vincepri approved these changes

@dlipovetsky dlipovetsky Awaiting requested review from dlipovetsky

@faiq faiq Awaiting requested review from faiq

Assignees

@muraee muraee

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@stevekuznetsov @k8s-ci-robot @muraee @vincepri