Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Add support for Ignition v3 Proxy and TLS #4750

Merged
merged 1 commit into from
Mar 6, 2024
Merged

🌱 Add support for Ignition v3 Proxy and TLS #4750

merged 1 commit into from
Mar 6, 2024

Conversation

vincepri
Copy link
Member

What type of PR is this?

/kind feature
What this PR does / why we need it:

From Ignition v3.1 there is support in the struct to setup a proxy, and CA validation. This changeset allows AWSMachines to expose these features when using Ignition.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Checklist:

  • squashed commits
  • includes documentation
  • includes emojis
  • adds unit tests
  • adds or updates e2e tests

Release note:

Ignition, from v3.1, now supports including Proxy or CA bundle data.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority labels Jan 19, 2024
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 19, 2024
@vincepri vincepri changed the title Add support for Ignition v3 Proxy and TLS 🌱 Add support for Ignition v3 Proxy and TLS Jan 19, 2024
@vincepri
Copy link
Member Author

/retest

@vincepri vincepri force-pushed the addproxytls-ignition branch 2 times, most recently from 893f76a to 525d895 Compare January 19, 2024 16:56
JoelSpeed
JoelSpeed reviewed Jan 19, 2024
View reviewed changes
api/v1beta2/awsmachine_types.go Outdated Show resolved Hide resolved
api/v1beta2/awsmachine_types.go Outdated Show resolved Hide resolved
api/v1beta2/awsmachine_types.go Show resolved Hide resolved
api/v1beta2/awsmachine_types.go Show resolved Hide resolved
api/v1beta2/awsmachine_types.go Outdated Show resolved Hide resolved
@vincepri vincepri force-pushed the addproxytls-ignition branch from 525d895 to 8db9d5f Compare January 19, 2024 18:32
patrickdillon
patrickdillon reviewed Jan 25, 2024
View reviewed changes
api/v1beta2/awsmachine_types.go Outdated Show resolved Hide resolved
api/v1beta2/awsmachine_types.go Outdated Show resolved Hide resolved
api/v1beta2/awsmachine_types.go Outdated Show resolved Hide resolved
@vincepri vincepri force-pushed the addproxytls-ignition branch from 8db9d5f to 7de913e Compare January 25, 2024 17:06
@vincepri
Copy link
Member Author

vincepri commented Feb 1, 2024

/milestone v2.4.0

@k8s-ci-robot
Copy link
Contributor

@vincepri: You must be a member of the kubernetes-sigs/cluster-api-provider-aws-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your Cluster API Provider AWS Maintainers and have them propose you as an additional delegate for this responsibility.

In response to this:

/milestone v2.4.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vincepri vincepri force-pushed the addproxytls-ignition branch from 7de913e to 91fea85 Compare February 1, 2024 18:33
@richardcase
Copy link
Member

/milestone v2.4.0

@k8s-ci-robot k8s-ci-robot added this to the v2.4.0 milestone Feb 5, 2024
@richardcase
Copy link
Member

This looks good to me. It would be good to mark conversations as resolved and then hopefully someone will lgtm.

JoelSpeed
JoelSpeed reviewed Feb 7, 2024
View reviewed changes
api/v1beta2/awsmachine_types.go Show resolved Hide resolved
api/v1beta2/awsmachine_types.go Outdated Show resolved Hide resolved
api/v1beta2/awsmachine_types.go Show resolved Hide resolved
api/v1beta2/awsmachine_types.go Show resolved Hide resolved
api/v1beta2/awsmachine_types.go Outdated Show resolved Hide resolved
api/v1beta2/awsmachine_types.go Show resolved Hide resolved
api/v1beta2/awsmachine_types.go Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 13, 2024
@vincepri vincepri force-pushed the addproxytls-ignition branch from 91fea85 to c8cdd99 Compare February 20, 2024 22:31
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 20, 2024
@vincepri vincepri force-pushed the addproxytls-ignition branch 3 times, most recently from 3a224ae to d291657 Compare February 22, 2024 15:47
JoelSpeed
JoelSpeed reviewed Feb 22, 2024
View reviewed changes
api/v1beta2/awsmachine_types.go Outdated Show resolved Hide resolved
api/v1beta2/awsmachine_types.go Outdated Show resolved Hide resolved
@vincepri vincepri force-pushed the addproxytls-ignition branch from d291657 to bc5ce11 Compare February 23, 2024 04:18
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 23, 2024
@vincepri vincepri force-pushed the addproxytls-ignition branch 2 times, most recently from 346efc3 to 23d4a5c Compare February 23, 2024 17:56
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Feb 23, 2024
@vincepri
Copy link
Member Author

vincepri commented Mar 1, 2024

/retest

@vincepri
Copy link
Member Author

vincepri commented Mar 6, 2024

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 6, 2024
@vincepri
Add support for Ignition v3 Proxy and TLS
4073507 
From Ignition v3.1 there is support in the struct to setup a proxy, and
CA validation. This changeset allows AWSMachines to expose these
features when using Ignition.

Signed-off-by: Vince Prignano <[email protected]>
@vincepri vincepri force-pushed the addproxytls-ignition branch from 23d4a5c to 4073507 Compare March 6, 2024 17:00
@nrb
Copy link
Contributor

nrb commented Mar 6, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 6, 2024
@k8s-ci-robot k8s-ci-robot merged commit b655f99 into kubernetes-sigs:main Mar 6, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoelSpeed JoelSpeed JoelSpeed left review comments

@patrickdillon patrickdillon patrickdillon left review comments

@nrb nrb nrb left review comments

@fiunchinho fiunchinho Awaiting requested review from fiunchinho

@luthermonson luthermonson Awaiting requested review from luthermonson

Assignees

@nrb nrb

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v2.4.0
Development

Successfully merging this pull request may close these issues.
6 participants
@vincepri @k8s-ci-robot @richardcase @nrb @patrickdillon @JoelSpeed