✨ Bump CAPI to v1.6.x #4739
✨ Bump CAPI to v1.6.x #4739
Conversation
k8s-ci-robot
added
kind/support
k8s-ci-robot
added
needs-priority
size/XXL
|
/retest |
|
/test pull-cluster-api-provider-aws-e2e |
3 similar comments
|
/test pull-cluster-api-provider-aws-e2e |
|
/test pull-cluster-api-provider-aws-e2e |
|
/test pull-cluster-api-provider-aws-e2e |
|
I now tried bumping to CAPI v1.6.1 instead as there is a fix around Upgrades and MachinePools. /test pull-cluster-api-provider-aws-e2e |
|
/retest |
pkg/cloud/scope/machine.go
Outdated
| @@ -386,3 +384,107 @@ func (m *MachineScope) SetInterruptible() { | |||
| m.AWSMachine.Status.Interruptible = true | |||
| } | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
Could you restructure this file more, such that declarations goes up in the file and function goes later?
There was a problem hiding this comment.
Yes, thinking about it, since this is a straight copy of a dependency we needed, it may be better to keep it into it's own separate file, in case we want to remove it in the future.
Added an extra providerid.go file for it.
|
/test pull-cluster-api-provider-aws-e2e |
1 similar comment
|
/test pull-cluster-api-provider-aws-e2e |
There was a problem hiding this comment.
Looks like the deploy is failing since you have bumped controller runtime with this bump.
6:43:19 PM: # sigs.k8s.io/controller-runtime/pkg/cache
6:43:19 PM: /opt/buildhome/.gimme_cache/gopath/pkg/mod/sigs.k8s.io/[email protected]/pkg/cache/cache.go:412:58: fields.Selector does not implement comparable
6:43:19 PM: /opt/buildhome/.gimme_cache/gopath/pkg/mod/sigs.k8s.io/[email protected]/pkg/cache/cache.go:442:20: fields.Selector does not implement comparable
|
@Ankitasw yes, and the following line states Although I thought Netlify build environment already had Go 1.21 (see here) or am I missing something? |
|
@Ankitasw Ok with a bit of trial and error the netlify deploy issue was due to the fact that the cluster-api-provider-aws/netlify.toml Line 7 in c777c9d |
|
/test pull-cluster-api-provider-aws-e2e |
|
/test pull-cluster-api-provider-aws-e2e |
|
Ok I now tried adding some debug details to track down the reason for the VPC creation failure /test pull-cluster-api-provider-aws-e2e |
following the deprecation of noderefutil, the package has now been removed from cluster-api
|
/test pull-cluster-api-provider-aws-e2e |
|
It looks like the e2e EKS flaked early |
|
/test pull-cluster-api-provider-aws-e2e |
|
Finally it looks like e2e passed 🎉 |
|
@damdo: GitHub didn't allow me to assign the following users: dilyevsky. Note that only kubernetes-sigs members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
/label tide/merge-method-squash |
k8s-ci-robot
added
the
tide/merge-method-squash
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
What type of PR is this?
/kind support
What this PR does / why we need it:
Bumps CAPI to v1.6.x based on https://github.com/kubernetes-sigs/cluster-api/blob/main/docs/book/src/developer/providers/migrations/v1.5-to-v1.6.md
Partially based on #4569
Special notes for your reviewer:
Worth reviewing per commit
Checklist:
Release note: