Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump golangci-lint dependency #4612

Merged
merged 1 commit into from
Nov 10, 2023
Merged

Bump golangci-lint dependency #4612

merged 1 commit into from
Nov 10, 2023

Conversation

Ankitasw
Copy link
Member

@Ankitasw Ankitasw commented Nov 3, 2023 •
edited
Loading

What type of PR is this?
/kind support

What this PR does / why we need it:
This PR bumps following deps manually:
Bump Golangci lint to v1.55.2

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Checklist:

  • squashed commits
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

Release note:

Bump dependencies

@k8s-ci-robot k8s-ci-robot added kind/support Categorizes issue or PR as a support question. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 3, 2023
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Nov 3, 2023
@Ankitasw Ankitasw force-pushed the bump-deps branch 2 times, most recently from 8a4a278 to e904ef7 Compare November 3, 2023 13:50
@Ankitasw Ankitasw changed the title Bump dependencies manually [WIP] Bump dependencies manually Nov 3, 2023
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 3, 2023
@Ankitasw Ankitasw changed the title [WIP] Bump dependencies manually Bump dependencies manually Nov 3, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 3, 2023
@Ankitasw Ankitasw changed the title Bump dependencies manually Bump golangci-lint dependency Nov 3, 2023
@Ankitasw Ankitasw force-pushed the bump-deps branch 2 times, most recently from 626cc04 to 115131e Compare November 3, 2023 16:55
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 3, 2023
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 9, 2023
@Ankitasw
Copy link
Member Author

Ankitasw commented Nov 9, 2023

PR ready for review.

@Ankitasw
Copy link
Member Author

Ankitasw commented Nov 9, 2023

/test pull-cluster-api-provider-aws-e2e-blocking

@fiunchinho
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 9, 2023
@Ankitasw
Copy link
Member Author

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ankitasw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 10, 2023
@k8s-ci-robot k8s-ci-robot merged commit 90a14b0 into kubernetes-sigs:main Nov 10, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fiunchinho fiunchinho Awaiting requested review from fiunchinho

@richardcase richardcase Awaiting requested review from richardcase

Assignees

@fiunchinho fiunchinho

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/support Categorizes issue or PR as a support question. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Ankitasw @fiunchinho @k8s-ci-robot