🐛 On deletion, should ignore if the secret cannot be found #4557
Conversation
Signed-off-by: Vince Prignano <[email protected]>
k8s-ci-robot
added
release-note-none
k8s-ci-robot
added
needs-priority
size/XS
|
/assign @JoelSpeed @richardcase @Skarlso |
|
I swear I've seen this one before. 🤣🤣 |
| @@ -777,7 +777,7 @@ func (r *AWSMachineReconciler) ignitionUserData(scope *scope.MachineScope, objec | |||
|
|
|||
| func (r *AWSMachineReconciler) deleteBootstrapData(machineScope *scope.MachineScope, clusterScope cloud.ClusterScoper, objectStoreScope scope.S3Scope) error { | |||
| _, userDataFormat, err := machineScope.GetRawBootstrapDataWithFormat() | |||
| if err != nil { | |||
| if client.IgnoreNotFound(err) != nil { | |||
There was a problem hiding this comment.
To be consistent across, can we use apierrors.IsNotFound(err) here?
There was a problem hiding this comment.
We added this in controller runtime to be easier for folks to deal with, I don't have a strong opinion on either; but this requires one less import in general, and it's a bit easier to read
|
/test pull-cluster-api-provider-aws-e2e-blocking |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Ankitasw The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
What type of PR is this?
/kind bug
What this PR does / why we need it:
If a Machine fails to bootstrap due to a problem with the bootstrap secret (which is generated separately), when the AWSMachine tries to delete the machine, it can get stuck trying to find that secret. Ignore not found errors.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Checklist:
Release note: