Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Allow ESP protocol to be set in IngressRules #4552

Merged
merged 1 commit into from
Oct 16, 2023

Conversation

vincepri
Copy link
Member

@vincepri vincepri commented Oct 6, 2023

What type of PR is this?

What this PR does / why we need it:
/kind feature

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Checklist:

  • squashed commits
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/feature Categorizes issue or PR as related to a new feature. labels Oct 6, 2023
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 6, 2023
@vincepri
Copy link
Member Author

vincepri commented Oct 6, 2023

/assign @nrb @JoelSpeed @richardcase

@JoelSpeed
Copy link

This is required for IPSEC in OVN Kubernetes. I've tested this and it works as expected.
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 9, 2023
@Skarlso
Copy link
Contributor

Skarlso commented Oct 9, 2023

Hi.

Please include an issue that has been triaged or talked about in any way.

This is required for IPSEC in OVN Kubernetes. I've tested this and it works as expected.

Can you include any logs or screenshots of the port number being correctly configured?

Thanks.

@JoelSpeed
Copy link

This was configured in the CNI ingress rules for my AWSCluster:
Screenshot 2023-10-09 at 12 27 59
This is from the status of the AWS Cluster:
Screenshot 2023-10-09 at 12 27 38
This is from the AWS console showing the rules in the security group:
Screenshot 2023-10-09 at 12 28 56

@Skarlso
Copy link
Contributor

Skarlso commented Oct 9, 2023

Thanks! :)

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 9, 2023
Copy link
Member

@Ankitasw Ankitasw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also add this in one of the existing E2E test to see if it works?

@vincepri
Copy link
Member Author

@Ankitasw done

@vincepri
Copy link
Member Author

/test ?

@vincepri
Copy link
Member Author

/test pull-cluster-api-provider-aws-e2e

@JoelSpeed
Copy link

E2E looking good now
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 16, 2023
@vincepri
Copy link
Member Author

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 16, 2023
@k8s-ci-robot k8s-ci-robot merged commit a2e7360 into kubernetes-sigs:main Oct 16, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants