-
Notifications
You must be signed in to change notification settings - Fork 578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Allow ESP protocol to be set in IngressRules #4552
Conversation
/assign @nrb @JoelSpeed @richardcase |
This is required for IPSEC in OVN Kubernetes. I've tested this and it works as expected. |
Hi. Please include an issue that has been triaged or talked about in any way.
Can you include any logs or screenshots of the port number being correctly configured? Thanks. |
Thanks! :) |
a93f785
to
c15f43f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we also add this in one of the existing E2E test to see if it works?
c15f43f
to
4fc1ba7
Compare
@Ankitasw done |
/test ? |
/test pull-cluster-api-provider-aws-e2e |
...infrastructure-aws/withoutclusterclass/e2e_test_templates/cluster-template-internal-elb.yaml
Show resolved
Hide resolved
Signed-off-by: Vince Prignano <[email protected]>
4fc1ba7
to
9528f42
Compare
E2E looking good now |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
What this PR does / why we need it:
/kind feature
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Checklist:
Release note: