Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PROPOSAL] Reviewer and maintainer changes #4536

Merged
merged 2 commits into from
Oct 16, 2023
Merged

[PROPOSAL] Reviewer and maintainer changes #4536

merged 2 commits into from
Oct 16, 2023

Conversation

richardcase
Copy link
Member

@richardcase richardcase commented Oct 4, 2023 •
edited by Ankitasw
Loading

What type of PR is this?

/kind feature

What this PR does / why we need it:

This PR makes the following changes:

  • @cnmcavoy moves to reviewer
  • @nrb moves to reviewer
  • @faiq moves to reviewer
  • @vincepri moves from emeritus to maintainer
  • @shivi28 moves to emeritus reviewer
  • @dthorsen moves to emeritus reviewer
  • @pydctw moves to emeritus reviewer
  • Updates the owner alias with changes in CAPI / SIG cluster lifecycle leads

For anyone moving to emeritus, if you feel you want to move back to reviewer in th efuture feel free to reach out to any of the maintainers to discuss.

Release note:

Maintainer and reviewer changes.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. labels Oct 4, 2023
@k8s-ci-robot k8s-ci-robot added needs-priority size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 4, 2023
@richardcase
Copy link
Member Author

As per our contributing guidelines this will be open for comment until after the office hours on Monday 16th October:

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 4, 2023
@enxebre
Copy link
Member

enxebre commented Oct 4, 2023

+1

1 similar comment
@Skarlso
Copy link
Contributor

Skarlso commented Oct 4, 2023

+1

@Ankitasw
Copy link
Member

Ankitasw commented Oct 5, 2023

Huge +1 from my side!!!

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 6, 2023
@richardcase richardcase changed the title [PROPOSAL] Add Cameron as a reviewer [PROPOSAL] Reviewer and maintainer changes Oct 6, 2023
@richardcase
Copy link
Member Author

@enxebre @Skarlso @Ankitasw - Thanks for your +1 on moving @cnmcavoy to reviewer. The PR has now been updated with some additional changes:

  • @nrb moves to reviewer
  • @faiq moves to reviewer
  • @vincepri moves from emeritus to maintainer

Feel free to leave comments on these additional proposed changes.

@Ankitasw
Copy link
Member

Ankitasw commented Oct 9, 2023

+1 from my side

@vincepri
Copy link
Member

/retest

@dlipovetsky
Copy link
Contributor

+1

@Ankitasw
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 16, 2023
@richardcase
Copy link
Member Author

After lazy concensus:

/unhold
/approve

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 16, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ankitasw, richardcase

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Ankitasw,richardcase]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 2b25bdd into kubernetes-sigs:main Oct 16, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AverageMarcus AverageMarcus Awaiting requested review from AverageMarcus

@luthermonson luthermonson Awaiting requested review from luthermonson

Assignees

@Ankitasw Ankitasw

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@richardcase @enxebre @Skarlso @Ankitasw @vincepri @dlipovetsky @k8s-ci-robot