Fix error loop for ignition

[odvarkadaniel]

What type of PR is this?
/kind bug

What this PR does / why we need it:
At the moment, if the user uses Ignition as a bootstrap configuration, the user face a breaking error loop that prevents them from using this option.
The change makes sure that after the machine is successfully created, the data secret content in the S3 bucket gets removed correctly.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #4489

Special notes for your reviewer:
With the change made, we needed to make sure to not break the unit tests that are already in place - we needed to add the secrets to the clients that didn't have it previously.

Checklist:

• squashed commits
• includes documentation
• adds unit tests
• adds or updates e2e tests

Release note:

NONE

[k8s-ci-robot]

Welcome @odvarkadaniel!

It looks like this is your first PR to kubernetes-sigs/cluster-api-provider-aws 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cluster-api-provider-aws has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @odvarkadaniel. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[Skarlso]

/ok-to-test

[Skarlso]

/test ?

[k8s-ci-robot]

@Skarlso: The following commands are available to trigger required jobs:

• /test pull-cluster-api-provider-aws-build
• /test pull-cluster-api-provider-aws-test
• /test pull-cluster-api-provider-aws-verify

The following commands are available to trigger optional jobs:

• /test pull-cluster-api-provider-aws-apidiff-main
• /test pull-cluster-api-provider-aws-e2e
• /test pull-cluster-api-provider-aws-e2e-blocking
• /test pull-cluster-api-provider-aws-e2e-clusterclass
• /test pull-cluster-api-provider-aws-e2e-conformance
• /test pull-cluster-api-provider-aws-e2e-conformance-with-ci-artifacts
• /test pull-cluster-api-provider-aws-e2e-eks
• /test pull-cluster-api-provider-aws-e2e-eks-gc
• /test pull-cluster-api-provider-aws-e2e-eks-testing

Use /test all to run the following jobs that were automatically triggered:

• pull-cluster-api-provider-aws-apidiff-main
• pull-cluster-api-provider-aws-build
• pull-cluster-api-provider-aws-test
• pull-cluster-api-provider-aws-verify

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[Skarlso]

/test pull-cluster-api-provider-aws-e2e

[Ankitasw]

@odvarkadaniel is this tested locally?

[odvarkadaniel]

@odvarkadaniel is this tested locally?

About to do that today. I will come back with the results once done.

[odvarkadaniel]

cc/ @JoelSpeed

[odvarkadaniel]

@odvarkadaniel is this tested locally?

@Ankitasw, just tested this manually using Kind as management cluster with ignition as a bootstrap config. Created a workload AWS cluster with a control plane machine with OS flatcar-stable with Kubernetes version 1.27.0 and the machine became Running and the S3 unneeded entries were deleted according to the logs of the controller correctly.
As I can see, this change should not temper at all with the functionality of CloudInit.

[Ankitasw]

Thankyou @odvarkadaniel

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ankitasw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [Ankitasw]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[Ankitasw]

/cherry-pick release-2.2

[k8s-infra-cherrypick-robot]

@Ankitasw: new pull request created: #4497

In response to this:

/cherry-pick release-2.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.