-
Notifications
You must be signed in to change notification settings - Fork 578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace all AWS SDK calls with their WithContext analogs #4490
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are not passing the context top down still. all the contexts are TODO, so it still not serve the purpose that is stated in the PR
8653e21
to
8c1c46c
Compare
@Ankitasw yeah, you are right, the description is a bit confusing. I updated it to make it more explicit that in this PR we just replace SDK calls, and all work about passing contexts will be done in the following PRs. |
8c1c46c
to
b7dd11d
Compare
Given that this is the first step in a series of work, replacing the calls with their context-aware equivalents and |
@Fedosin if this is going to be a series of work, can we have a consolidated issue created with the task list? |
Thanks folks! I created an issue for this work: #4504 |
Thanks @Fedosin , if you have a plan of work, could you mention all the work items in above issue? |
Not an official reviewer, but I did another pass focusing on the tests, and this appears to pretty much be straight replacements like I mentioned before. There are some functions that are expanded to receive LGTM aside from some tracking requests on the issue. |
b7dd11d
to
08443de
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Ankitasw The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind support
What this PR does / why we need it:
This is the first PR in a series.
Now we don't pass context from
Reconcile
functions to AWS SDK calls, which limits our ability to trace requests using OpenTelemetry. To improve this we want to start passing context from top to bottom.In this PR we just replace AWS SDK calls with their
WithContext
analogs, so that they can accept a context parameter. In the following PRs we are going to start passing context fromReconcile
to the SDK calls.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Partially-Fixes #4504
Special notes for your reviewer:
Checklist:
Release note: