-
Notifications
You must be signed in to change notification settings - Fork 579
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📖 Added CAPA own getting-started instead of using CAPI embedded getting-started #4082
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
See the [clusterctl] documentation for more detail about clusterctl supported actions. | ||
|
||
<!-- links --> | ||
[Experimental Features]: https://cluster-api.sigs.k8s.io/tasks/experimental-features/experimental-features.html |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we don't need other providers links here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure I will remove the unnecessary links from here.
thanks for pointing out it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please fix below error in md-lint?
Error: src/getting-started.md: link "./topics/reference/glossary.md#bootstrap-cluster" points to a non-existing slug
@Ankitasw I have mentioned above 3 approaches. By these all 3 approaches md-lint error will be gone. |
I miss to find the approaches, could you paste it here again? |
Here we are using embeded glosary.md. So when we are doing glossary.md#bootstrap-cluster then the workflow are not able to identify it so it is showing error because in CAPA glosary there is nothing related to #bootstrap-cluster.
|
So the first one is not an option for us, we cannot ignore this error as it will fail for other PRs as well. |
Hey @hackeramitkumar do you need any help here? |
@Ankitasw thanks for asking. I have almost done it. I will complete it till tomorrow. |
No hurry, take your time 😄 |
@Ankitasw please review it. And let me know if any changes are required... |
[management cluster]: ./topics/reference/glossary.md | ||
[KubeVirt]: https://kubevirt.io/ | ||
[provider components]: ./topics/reference/glossary.md | ||
[workload cluster]: ./topics/reference/glossary.md |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This link still doesn't work, could you check it?
@hackeramitkumar do you need any support to continue this PR? |
@hackeramitkumar Are you still able to continue with this PR? Also, could you add |
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
@hackeramitkumar: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /close |
@k8s-triage-robot: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What type of PR is this?
/kind documentation
What this PR does / why we need it:
We are using CAPI embedded getting started. But that are causing many broken links and also have extra informations that are not required for CAPA users.
So I have added CAPA own getting-started.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #4067
Special notes for your reviewer:
Checklist:
Release note: