Skip to content

Commit

Permalink
Remove CoreDNS from EKS addon tests
Browse files Browse the repository at this point in the history
While it may have worked in the past, CoreDNS no longer installs when
there is just an EKS control plane. A user must also create a nodegroup
for CoreDNS pods to be scheduled.

Signed-off-by: Nolan Brubaker <[email protected]>
  • Loading branch information
nrb committed Dec 5, 2024
1 parent 9b65314 commit e871b23
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 26 deletions.
2 changes: 0 additions & 2 deletions test/e2e/data/e2e_eks_conf.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -127,8 +127,6 @@ variables:
EXP_EKS_IAM: "false"
EXP_EKS_ADD_ROLES: "false"
VPC_ADDON_VERSION: "v1.18.1-eksbuild.3"
COREDNS_ADDON_VERSION: "v1.11.1-eksbuild.8"
COREDNS_ADDON_CONFIGURATION: '{"replicaCount":3}'
KUBE_PROXY_ADDON_VERSION: "v1.30.0-eksbuild.3"
CONFORMANCE_CI_ARTIFACTS_KUBERNETES_VERSION: "1.30.2"
IP_FAMILY: "IPv4"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -40,10 +40,6 @@ spec:
- name: "vpc-cni"
version: "${VPC_ADDON_VERSION}"
conflictResolution: "overwrite"
- name: "coredns"
version: "${COREDNS_ADDON_VERSION}"
conflictResolution: "overwrite"
configuration: '${COREDNS_ADDON_CONFIGURATION}'
identityRef:
kind: AWSClusterStaticIdentity
name: e2e-account
Expand Down
25 changes: 5 additions & 20 deletions test/e2e/suites/managed/eks_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -37,12 +37,11 @@ import (
// General EKS e2e test.
var _ = ginkgo.Describe("[managed] [general] EKS cluster tests", func() {
var (
namespace *corev1.Namespace
ctx context.Context
specName = "cluster"
clusterName string
cniAddonName = "vpc-cni"
corednsAddonName = "coredns"
namespace *corev1.Namespace
ctx context.Context
specName = "cluster"
clusterName string
cniAddonName = "vpc-cni"
)

shared.ConditionalIt(runGeneralTests, "should create a cluster and add nodes", func() {
Expand Down Expand Up @@ -107,20 +106,6 @@ var _ = ginkgo.Describe("[managed] [general] EKS cluster tests", func() {
}
})

ginkgo.By("should have the Coredns addon installed")
CheckAddonExistsSpec(ctx, func() CheckAddonExistsSpecInput {
return CheckAddonExistsSpecInput{
E2EConfig: e2eCtx.E2EConfig,
BootstrapClusterProxy: e2eCtx.Environment.BootstrapClusterProxy,
AWSSession: e2eCtx.BootstrapUserAWSSession,
Namespace: namespace,
ClusterName: clusterName,
AddonName: corednsAddonName,
AddonVersion: e2eCtx.E2EConfig.GetVariable(shared.CorednsAddonVersion),
AddonConfiguration: e2eCtx.E2EConfig.GetVariable(shared.CorednsAddonConfiguration),
}
})

ginkgo.By("should create a MachineDeployment")
MachineDeploymentSpec(ctx, func() MachineDeploymentSpecInput {
return MachineDeploymentSpecInput{
Expand Down

0 comments on commit e871b23

Please sign in to comment.