Merge pull request #4579 from Skarlso/fix-tag-order

fix: sorting the tags list to make it determined
kubernetes-sigs · Oct 16, 2023 · 5d1cb0f · 5d1cb0f
2 parents 076f360 + a900cec
commit 5d1cb0f
Showing 1 changed file with 5 additions and 0 deletions.
diff --git a/pkg/cloud/services/s3/s3.go b/pkg/cloud/services/s3/s3.go
@@ -22,6 +22,7 @@ import (
 	"fmt"
 	"net/url"
 	"path"
+	"sort"
 
 	"github.com/aws/aws-sdk-go/aws"
 	"github.com/aws/aws-sdk-go/aws/awserr"
@@ -272,6 +273,10 @@ func (s *Service) tagBucket(bucketName string) error {
 		})
 	}
 
+	sort.Slice(taggingInput.Tagging.TagSet, func(i, j int) bool {
+		return *taggingInput.Tagging.TagSet[i].Key < *taggingInput.Tagging.TagSet[j].Key
+	})
+
 	_, err := s.S3Client.PutBucketTagging(taggingInput)
 	if err != nil {
 		return err