Merge pull request #4463 from pluralsh/fixx-node-role-name

fix: don't generate nodegroup role name starting with hyphen
kubernetes-sigs · Sep 25, 2023 · 526cedf · 526cedf
2 parents 7e3d2cd + 22de8bb
commit 526cedf
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/pkg/cloud/services/eks/roles.go b/pkg/cloud/services/eks/roles.go
@@ -182,8 +182,8 @@ func (s *NodegroupService) reconcileNodegroupIAMRole() error {
 		} else {
 			s.scope.Info("no EKS nodegroup role specified, using role based on nodegroup name")
 			roleName, err = eks.GenerateEKSName(
+				"nodegroup-iam-service-role",
 				fmt.Sprintf("%s-%s", s.scope.KubernetesClusterName(), s.scope.NodegroupName()),
-				"-nodegroup-iam-service-role",
 				maxIAMRoleNameLength,
 			)
 			if err != nil {