-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Skip reconciliation if deleting cluster #328
base: main
Are you sure you want to change the base?
✨ Skip reconciliation if deleting cluster #328
Conversation
Welcome @kahirokunn! |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: kahirokunn The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @kahirokunn. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
809ce86
to
f2070cd
Compare
f2070cd
to
7441987
Compare
7441987
to
fc28ee7
Compare
/ok-to-test |
Will approve once tests pass |
@Jont828 Thank you for letting me know! The tests have passed successfully, so I believe this is ready for your final approval. Please let me know if there's anything else you'd like me to address. 😊 |
Signed-off-by: kahirokunn <[email protected]>
fc28ee7
to
be00959
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/assign @Jont828
What this PR does / why we need it:
This PR introduces a feature to skip reconciliation when a cluster is in the process of being deleted. By checking the
DeletionTimestamp
of the cluster, the controller avoids creating or updatingHelmReleaseProxy
resources, ensuring a clean and efficient cluster teardown without unnecessary operations or potential errors.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #319 (comment)