Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken rules with Prometheus v3 #1006

Closed
wants to merge 1 commit into from
Closed

Fix broken rules with Prometheus v3 #1006

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,12 +23,15 @@ A set of Grafana dashboards and Prometheus alerts for Kubernetes.
| release-0.11 | v1.23+ | v2.11.0+ | v2.0+ |
| release-0.12 | v1.23+ | v2.11.0+ | v2.0+ |
| release-0.13 | v1.23+ | v2.11.0+ | v2.0+ |
| master | v1.26+ | v2.11.0+ | v2.0+ |
| master | v1.26+ | v3.0.0+ | v2.0+ |

In Kubernetes 1.14 there was a major [metrics overhaul](https://github.com/kubernetes/enhancements/issues/1206) implemented. Therefore v0.1.x of this repository is the last release to support Kubernetes 1.13 and previous version on a best effort basis.

Some alerts now use Prometheus filters made available in Prometheus 2.11.0, which makes this version of Prometheus a dependency.

With Prometheus v3, [histograms are normalized](https://prometheus.io/docs/prometheus/latest/migration/#le-and-quantile-label-values)
This breaks some of the recording rules that select on the `le` label.

Warning: This compatibility matrix was initially created based on experience, we do not guarantee the compatibility, it may be updated based on new learnings.

Warning: By default the expressions will generate *grafana 7.2+* compatible rules using the *$__rate_interval* variable for rate functions. If you need backward compatible rules please set *grafana72: false* in your *_config*
Expand Down
8 changes: 4 additions & 4 deletions rules/kube_apiserver-config.libsonnet
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,9 @@
// These are buckets that exist on the apiserver_request_sli_duration_seconds_bucket histogram.
// They are what the Kubernetes SIG Scalability is using to measure availability of Kubernetes clusters.
// If you want to change these, make sure the "le" buckets exist on the histogram!
kubeApiserverReadResourceLatency: '1',
kubeApiserverReadNamespaceLatency: '5',
kubeApiserverReadClusterLatency: '30',
kubeApiserverWriteLatency: '1',
kubeApiserverReadResourceLatency: '1.0',
kubeApiserverReadNamespaceLatency: '5.0',
kubeApiserverReadClusterLatency: '30.0',
kubeApiserverWriteLatency: '1.0',
},
}