Skip to content

Commit

Permalink
Merge pull request #826 from andyzhangx/use-onetag-e2e-test
Browse files Browse the repository at this point in the history
cleanup: use one image tag in e2e test
  • Loading branch information
andyzhangx authored Aug 17, 2024
2 parents c4994de + a069f6a commit 2356170
Showing 1 changed file with 3 additions and 8 deletions.
11 changes: 3 additions & 8 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -34,12 +34,7 @@ VERSION ?= latest
# Use a custom version for E2E tests if we are testing in CI
ifdef CI
ifndef PUBLISH
ifdef WINDOWS_SERVER_VERSION
override IMAGE_VERSION := e2e-$(WINDOWS_SERVER_VERSION)-$(GIT_COMMIT)
endif
ifdef EXTERNAL_E2E_TEST
override IMAGE_VERSION := e2e-external-$(GIT_COMMIT)
endif
override IMAGE_VERSION := e2e-$(GIT_COMMIT)
endif
endif
IMAGE_TAG = $(REGISTRY)/$(IMAGENAME):$(IMAGE_VERSION)
Expand Down Expand Up @@ -151,13 +146,13 @@ container: smb

.PHONY: container-linux
container-linux:
docker buildx build --pull --output=type=$(OUTPUT_TYPE) --platform="linux/$(ARCH)" \
docker buildx build --no-cache --pull --output=type=$(OUTPUT_TYPE) --platform="linux/$(ARCH)" \
--provenance=false --sbom=false \
-t $(IMAGE_TAG)-linux-$(ARCH) --build-arg ARCH=$(ARCH) -f ./cmd/smbplugin/Dockerfile .

.PHONY: container-linux-armv7
container-linux-armv7:
docker buildx build --pull --output=type=$(OUTPUT_TYPE) --platform="linux/arm/v7" \
docker buildx build --no-cache --pull --output=type=$(OUTPUT_TYPE) --platform="linux/arm/v7" \
--provenance=false --sbom=false \
-t $(IMAGE_TAG)-linux-arm-v7 --build-arg ARCH=arm/v7 -f ./cmd/smbplugin/Dockerfile .

Expand Down

0 comments on commit 2356170

Please sign in to comment.