pod should use mac and ips provider by multus firstly #4800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: clyi <[email protected]>
dosubot
bot
added
the
size:M
Pull Request Test Coverage Report for Build 12275027635Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
|
加个 e2e case？ |
zhangzujian
reviewed
Dec 9, 2024
pkg/controller/pod.go
Outdated
| if err := c.config.KubeOvnClient.KubeovnV1().IPs().Delete(context.Background(), portNeedDel, metav1.DeleteOptions{}); err != nil { | ||
| if !k8serrors.IsNotFound(err) { | ||
| klog.Errorf("failed to delete ip %s, %v", portNeedDel, err) | ||
| if len(portsNeedToDel) > 0 { |
zhangzujian
reviewed
Dec 9, 2024
Comment on lines
1230
to
1232
| if len(cachedPod.Annotations) == len(pod.Annotations) { | ||
| return pod, nil | ||
| } |
zhangzujian
reviewed
Dec 9, 2024
pkg/controller/pod.go
Outdated
Comment on lines
1575
to
1577
| if attach.MacRequest != "" { | ||
| ret.MacRequest = attach.MacRequest | ||
| } |
There was a problem hiding this comment.
Suggested change
| if attach.MacRequest != "" { | |
| ret.MacRequest = attach.MacRequest | |
| } | |
| ret.MacRequest = attach.MacRequest |
bobz965
reviewed
Dec 9, 2024
| annotationsNeedToAdd[fmt.Sprintf(util.IPAddressAnnotationTemplate, podNet.ProviderName)] = podNet.IPRequest | ||
| } | ||
|
|
||
| if podNet.MacRequest != "" { |
There was a problem hiding this comment.
如果用的不是 kubeovn 的 ip 和 mac，是不是补充个 log ？ 不然查问题的话，不确定 mac 和 ip 哪里来的
Signed-off-by: clyi <[email protected]>
1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
What type of this PR
Examples of user facing changes:
Which issue(s) this PR fixes
Fixes #(issue-number)