Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add nodeSelector for lb-svc #4793

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add nodeSelector for lb-svc #4793

wants to merge 1 commit into from

Conversation

hongzhen-ma
Copy link
Collaborator

Pull Request

What type of this PR

  • Features

Which issue(s) this PR fixes

Fixes #4756

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. feature New network feature labels Dec 5, 2024
@coveralls
Copy link

coveralls commented Dec 5, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 12177108988

Details

  • 0 of 25 (0.0%) changed or added relevant lines in 1 file are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.01%) to 18.664%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/controller/service_lb.go 0 25 0.0%
Files with Coverage Reduction New Missed Lines %
pkg/ovs/ovn-nb-port_group.go 2 82.53%
Totals Coverage Status
Change from base Build 12164445128: -0.01%
Covered Lines: 8680
Relevant Lines: 46507
💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
feature New network feature need backport size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature Request] NodeSelector for LoadBalancer Service Pod
2 participants
@hongzhen-ma @coveralls