Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add some unittests #4790

Merged
merged 1 commit into from
Dec 11, 2024
Merged

add some unittests #4790

merged 1 commit into from
Dec 11, 2024

Conversation

zhangzujian
Copy link
Member

Pull Request

What type of this PR

Examples of user facing changes:

  • Features
  • Bug fixes
  • Docs
  • Tests

Which issue(s) this PR fixes

Fixes #(issue-number)

@zhangzujian zhangzujian marked this pull request as ready for review December 4, 2024 06:49
@dosubot dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. test automation tests labels Dec 4, 2024
@zhangzujian zhangzujian marked this pull request as draft December 4, 2024 06:56
@coveralls
Copy link

coveralls commented Dec 4, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 12248441342

Details

  • 13 of 18 (72.22%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+3.2%) to 21.908%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/controller/vpc_egress_gateway.go 0 1 0.0%
pkg/controller/vpc.go 0 4 0.0%
Totals Coverage Status
Change from base Build 12247932946: 3.2%
Covered Lines: 10185
Relevant Lines: 46489
💛 - Coveralls

@zhangzujian zhangzujian marked this pull request as ready for review December 4, 2024 07:12
@dosubot dosubot bot added size:XXL This PR changes 1000+ lines, ignoring generated files. and removed size:XL This PR changes 500-999 lines, ignoring generated files. labels Dec 5, 2024
@zhangzujian zhangzujian force-pushed the ut branch 4 times, most recently from 9b4ddf6 to 496bd74 Compare December 10, 2024 02:47
@zhangzujian
add some unittests
2f5dd38 
Signed-off-by: zhangzujian <[email protected]>
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 10, 2024
@zhangzujian zhangzujian merged commit 1218d0b into kubeovn:master Dec 11, 2024
68 checks passed
@zhangzujian zhangzujian deleted the ut branch December 11, 2024 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bobz965 bobz965 bobz965 approved these changes

@oilbeater oilbeater Awaiting requested review from oilbeater

Assignees
No one assigned
Labels
lgtm This PR has been approved by a maintainer size:XXL This PR changes 1000+ lines, ignoring generated files. test automation tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zhangzujian @coveralls @bobz965