Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update device.go #82

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update device.go #82

wants to merge 1 commit into from

Conversation

alongL
Copy link
Contributor

@alongL alongL commented Sep 30, 2022

If Desired.Value is empty, don't set the value.

Maybe we should return only the Desired.Type is not string and value is null.

If Desired.Value is empty, don't set the value.
@kubeedge-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign luogangyi after the PR has been reviewed.
You can assign the PR to them by writing /assign @luogangyi in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubeedge-bot kubeedge-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 30, 2022
@sailorvii
Copy link
Collaborator

Thanks for the notice. However, the desired value could be empty when someone just care about the value but not setting it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants