Skip to content

Commit

Permalink
cc_maintainers: convert all addresses to lower case
Browse files Browse the repository at this point in the history
Heiner reports false positives when CC list and MAINTAINERS
differ on case.

Signed-off-by: Jakub Kicinski <[email protected]>
  • Loading branch information
kuba-moo committed Jan 6, 2025
1 parent 471071a commit 90af0b1
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
1 change: 1 addition & 0 deletions form-letters/net-next-closed
Original file line number Diff line number Diff line change
Expand Up @@ -9,3 +9,4 @@ RFC patches sent for review only are obviously welcome at any time.
See: https://www.kernel.org/doc/html/next/process/maintainer-netdev.html#development-cycle
--
pw-bot: defer
pv-bot: closed
6 changes: 3 additions & 3 deletions tests/patch/cc_maintainers/test.py
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ def cc_maintainers(tree, thing, result_dir) -> Tuple[int, str, str]:
addrs += msg.get_all('cc', [])
addrs += msg.get_all('from', [])
addrs += msg.get_all('sender', [])
included = set([e for n, e in email.utils.getaddresses(addrs)])
included = set([e.lower() for n, e in email.utils.getaddresses(addrs)])
out += ["=== Email ===",
f"From: {msg.get_all('from')}",
f"Included: {included}", ""]
Expand All @@ -174,7 +174,7 @@ def cc_maintainers(tree, thing, result_dir) -> Tuple[int, str, str]:
raw_gm.append(line.strip())
match = emailpat.search(line)
if match:
addr = match.group(1)
addr = match.group(1).lower()
expected.add(addr)
if 'blamed_fixes' in line:
blamed.add(addr)
Expand Down Expand Up @@ -226,7 +226,7 @@ def cc_maintainers(tree, thing, result_dir) -> Tuple[int, str, str]:
continue
for have in included:
if have in mmap_emails:
mapped.add(m)
mapped.add(m.lower())

found.update(mapped)
missing.difference_update(mapped)
Expand Down

0 comments on commit 90af0b1

Please sign in to comment.