Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR does the following:
Ctrl+T
which toggles (selects/unselects) all items in the list. Also, some tests for this feature are added.Tests
In order for the tests of this feature to work, I've had to update the version of
tcell
tov2.7.4
.With the old version (
v2.6.0
), the test reaches a deadlock when testing the multi-select functionality with manyKeyUp
s followed by someKeyTab
s. To reproduce, apply the following patch on a cleanmaster
:And then run
go test -c && ./go-fuzzyfinder.test
. You'll notice: