Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#60 implement backend for a to do list pt.2 #70

Merged
merged 17 commits into from
Oct 1, 2024
Merged

#60 implement backend for a to do list pt.2 #70

merged 17 commits into from
Oct 1, 2024

Conversation

mtracewicz
Copy link
Contributor

This is continued work on task #60, as I have mentioned before I'm splitting it to make it easier to review. There should be one more PR coming in some time.

This one has the following changes:

  • Begin implementation of Items, all methods are implemented but they still do need some polishing (for example there is no filtering on tags)
  • Refactor authorisation, so that userId check is done in one place instead of in every endpoint
    This is done in a filter, to test this You can manually modify RequestExtensions.UserId to return null and then not a valid Guid.
  • Introduce a Makefile for ease of development, just type make and You'r up and running

@mtracewicz
Closes #60
92ce193 
Move rename request parameters into class
@mtracewicz
Closes #60
9b34589 
TIDY: Move Log enricher into infrastructure project
@mtracewicz
Closes #60
536753d 
Add maping to a repsonse
@mtracewicz
Closes #60
b16cb56 
Add todo items and tags
@mtracewicz
Closes #60
a2854cc 
Base implementation of todo items operations
@mtracewicz
Closes #60
ed90653 
Add information about working with migrations in README
@mtracewicz
Closes #60
c5ddb62 
Imporve API response codes
@mtracewicz
Closes #60
390d44d 
Introduce and document a Makefile for ease of application launch
@mtracewicz
Closes #60
9cacf1e 
Introduce UserIdFilter to minimize code repetition in controllers
@mtracewicz
Closes #60
84564a3 
Refactor auth check to not be in controller endpoints
@mtracewicz
Closes #60
bd3598f 
Rename and make requests nested class
Add comment for UserId
@mtracewicz
Closes #60
9e11db1 
Introduce Item - List mapping
@mtracewicz mtracewicz added the backend Backend related stuff label Sep 27, 2024
@mtracewicz mtracewicz requested a review from Sojusan September 27, 2024 19:15
@mtracewicz
Closes #60
cd3369d 
Rename file to match class name
@mtracewicz
Closes #60
5eea349 
Add missing list change in update of an item
@mtracewicz
Closes #60
a331de9 
Fix typo
@github-actions GitHub Actions
Copy link

@Sojusan
Two days have passed since the last activity. Please take care of this PR.

Sojusan
Sojusan requested changes Oct 1, 2024
View reviewed changes
Copy link
Contributor

@Sojusan Sojusan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor things and some questions.

backend/src/infrastructure/Data/TodoService.cs Outdated Show resolved Hide resolved
backend/bruno/KSummarized/ToDo/Items/Delete.bru Outdated Show resolved Hide resolved
backend/bruno/KSummarized/ToDo/Items/Get.bru Outdated Show resolved Hide resolved
backend/bruno/KSummarized/ToDo/Items/List.bru Outdated Show resolved Hide resolved
backend/src/api/Controllers/TodoController.cs Outdated Show resolved Hide resolved
backend/src/core/TodoItem.cs Outdated Show resolved Hide resolved
backend/src/infrastructure/Data/ApplicationDbContext.cs Outdated Show resolved Hide resolved
backend/src/infrastructure/Data/TodoItemModel.cs Outdated Show resolved Hide resolved
backend/src/infrastructure/LoggingExtensions.cs Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@mtracewicz
Closes #60
c2ba0a0 
Addressing PR comments
@mtracewicz
Closes #60
a6818ea 
Addressing PR issues
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Oct 1, 2024

Quality Gate Failed Quality Gate failed for 'ksummarized_ksummarized.com_backend'

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

Sojusan
Sojusan approved these changes Oct 1, 2024
View reviewed changes
Copy link
Contributor

@Sojusan Sojusan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@mtracewicz mtracewicz merged commit 448b4eb into master Oct 1, 2024
1 of 4 checks passed
@mtracewicz mtracewicz deleted the 00060_Implement_backend_for_a_ToDo_list branch October 1, 2024 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sojusan Sojusan Sojusan approved these changes

Assignees
No one assigned
Labels
backend Backend related stuff
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mtracewicz @Sojusan