Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #67 Hot-reload the code in the containers #69

Merged
merged 4 commits into from
Sep 23, 2024

Conversation

Sojusan
Copy link
Contributor

@Sojusan Sojusan commented Sep 19, 2024

  • Add the Docker developer option to live-update the files inside the containers for frontend and backend.
  • Add the development section to the backend Dockerfile. This section is run with docker-compose.
  • Adjusted the npm dev command to include the host and the port.
  • Removed unused import on the frontend.

⚠️ I have also added the note to the README file. Please read it before trying to work with the feature as there is information about the limitations of the current solution.

* Add the Docker `developer` option to live-update the files inside the containers for frontend and backend.
* Add the `development` section to the backend Dockerfile. This section is run with docker-compose.
* Adjusted the npm `dev` command to include the host and the port.
* Removed unused import on frontend.
Update the README
@Sojusan Sojusan added the general Item not related to Frontend and label Sep 19, 2024
@Sojusan Sojusan self-assigned this Sep 19, 2024
@Sojusan Sojusan requested a review from mtracewicz September 19, 2024 14:02
@Sojusan Sojusan linked an issue Sep 19, 2024 that may be closed by this pull request
@Sojusan Sojusan changed the title #67 Hot-reload the code in the containers Closes #67 Hot-reload the code in the containers Sep 19, 2024
Copy link
Contributor

@mtracewicz mtracewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have put in some minor questions. One more thing is that it might be worth to mention in README that You need to be logged into Docker Desktop to use --watch, it does not work for anonymous users

frontend/package.json Outdated Show resolved Hide resolved
frontend/package.json Show resolved Hide resolved
docker-compose.yml Outdated Show resolved Hide resolved
Copy link
Contributor

@mtracewicz mtracewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have put in some minor questions. One more thing is that it might be worth to mention in README that You need to be logged into Docker Desktop to use --watch, it does not work for anonymous users

Copy link
Contributor

@mtracewicz mtracewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have put in some minor questions. One more thing is that it might be worth to mention in README that You need to be logged into Docker Desktop to use --watch, it does not work for anonymous users

Add docker compose profile feature to turn on/off the hot-reload.
@Sojusan
Copy link
Contributor Author

Sojusan commented Sep 22, 2024

I have put in some minor questions. One more thing is that it might be worth mentioning in README that You need to be logged in to Docker Desktop to use --watch, it does not work for anonymous users

According to the official Docker website, the sign-in benefits are just some more pull ranges.
On the watch functionality documentation also there is nothing about being logged into Docker Desktop.
I'm using it without logging into the Docker Desktop, and it is working fine.
Can you share with me the error you have got?

Add missing docs in README
Copy link

Quality Gate Passed Quality Gate passed for 'ksummarized_ksummarized.com_frontend'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@mtracewicz
Copy link
Contributor

I have put in some minor questions. One more thing is that it might be worth mentioning in README that You need to be logged in to Docker Desktop to use --watch, it does not work for anonymous users

According to the official Docker website, the sign-in benefits are just some more pull ranges. On the watch functionality documentation also there is nothing about being logged into Docker Desktop. I'm using it without logging into the Docker Desktop, and it is working fine. Can you share with me the error you have got?

You are right. I have just retried it after logging out and this time it worked 🤷🏼 Maybe some issue on my side before.

Copy link
Contributor

@mtracewicz mtracewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚢

@Sojusan Sojusan merged commit a728d40 into master Sep 23, 2024
3 checks passed
@Sojusan Sojusan deleted the 00067_docker_code_hot_reload branch September 23, 2024 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
general Item not related to Frontend and
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve DX (Developer Expirience)
2 participants