Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

00060 implement backend for a to do list Pt. 1 #64

Merged
merged 15 commits into from
Sep 11, 2024
Merged

00060 implement backend for a to do list Pt. 1 #64

merged 15 commits into from
Sep 11, 2024

Conversation

mtracewicz
Copy link
Contributor

@mtracewicz mtracewicz commented Sep 9, 2024 •
edited
Loading

Because of the amount of changes required for this ticket I have decided to split it in two for the ease of reviewing.

This first part contains a bump to .net8, splitting backend into projects, introduction of a bruno collection and the initial implementation for todo list.

For now the supported operations are:

  • Create
  • Rename
  • Delete
  • Get
  • List (there is no filtering and no sorting)

@mtracewicz
Closes #60
691090d 
Introduce Bruno collection for easy API testing
@mtracewicz
Closes #60
155eb65 
Small refactoring.
Bump up package with vulnerability.
Remove not needed global.json file
@mtracewicz
Closes #60
1e7f2bd 
Initial implementation of getting all of users Todo Lists.
@mtracewicz
Closes #60
e29add6 
Upgrade to .net 8
@mtracewicz
Closes #60
59edf1d 
Add Logs
Remove the redirect for debuging
@mtracewicz
Closes #60
6601d55 
Update Bruno collections
@mtracewicz
Closes #60
8d13eca 
Remove unused using
@mtracewicz
Closes #60
7a5f829 
Add Create List
@mtracewicz
Closes #60
87de18e 
Implement get for a single list
@mtracewicz mtracewicz force-pushed the 00060_Implement_backend_for_a_ToDo_list branch from 55e3679 to 87de18e Compare September 10, 2024 11:16
@mtracewicz
Closes #60
afb8c67 
Add deletion of a list
@mtracewicz
Closes #60
52034da 
Cleanup sln
@mtracewicz
Closes #60
75c5880 
Add renamming of lists
@mtracewicz
Closes #60
3436b38 
Updated Bruno collection
@mtracewicz mtracewicz changed the title 00060 implement backend for a to do list 00060 implement backend for a to do list Pt. 1 Sep 10, 2024
@mtracewicz mtracewicz requested a review from Sojusan September 10, 2024 18:16
@mtracewicz mtracewicz marked this pull request as ready for review September 10, 2024 18:16
@mtracewicz
Closes #60
08ff0b7 
Modularize backend
Sojusan
Sojusan requested changes Sep 11, 2024
View reviewed changes
Copy link
Contributor

@Sojusan Sojusan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor things to consider.

backend/bruno/KSummarized/ToDo/List/Create.bru Outdated Show resolved Hide resolved
backend/bruno/KSummarized/ToDo/List/Create.bru Outdated Show resolved Hide resolved
backend/src/api/Controllers/TodoController.cs Outdated Show resolved Hide resolved
@mtracewicz
Closes #60
7d2e6a5 
Address code review comments
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'ksummarized_ksummarized.com_frontend'

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed for 'ksummarized_ksummarized.com_backend'

Failed conditions
1 Security Hotspot
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

Sojusan
Sojusan approved these changes Sep 11, 2024
View reviewed changes
Copy link
Contributor

@Sojusan Sojusan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mtracewicz mtracewicz merged commit 18da5bc into master Sep 11, 2024
5 of 7 checks passed
@mtracewicz mtracewicz deleted the 00060_Implement_backend_for_a_ToDo_list branch September 11, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sojusan Sojusan Sojusan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mtracewicz @Sojusan