Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closes #58 Replace MUI with Tailwindcss #59

Merged
merged 2 commits into from
Nov 21, 2023
Merged

Closes #58 Replace MUI with Tailwindcss #59

merged 2 commits into from
Nov 21, 2023

Conversation

Sojusan
Copy link
Contributor

@Sojusan Sojusan commented Sep 13, 2023 •
edited
Loading

I have removed mui from our project and configured tailwindcss.
I also fixed the files to be using tailwindcss approach instead of mui imports.
I didn't recreate the layout of our application, as it is going to be changed in the near future.

  • Fix the failing pipeline

@Sojusan
Closes #58
2f42e42 
Replaced MUI with Tailwindcss.
@Sojusan Sojusan requested a review from mtracewicz September 13, 2023 21:10
@Sojusan Sojusan self-assigned this Sep 13, 2023
@Sojusan Sojusan added the enhancement Improvement in existing functionality label Sep 13, 2023
@Sojusan Sojusan marked this pull request as draft September 13, 2023 21:12
@Sojusan
Closes #58
a3ad09d 
Change logos names and fix lint errors.
@sonarqubecloud
Copy link

[ksummarized_ksummarized.com_frontend] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Sojusan Sojusan marked this pull request as ready for review September 21, 2023 06:56
@github-actions
Copy link

@mtracewicz
Two days have passed since the last activity. Please take care of this PR.

21 similar comments
@github-actions
Copy link

@mtracewicz
Two days have passed since the last activity. Please take care of this PR.

@github-actions
Copy link

@mtracewicz
Two days have passed since the last activity. Please take care of this PR.

@github-actions
Copy link

github-actions bot commented Oct 2, 2023

@mtracewicz
Two days have passed since the last activity. Please take care of this PR.

@github-actions
Copy link

github-actions bot commented Oct 4, 2023

@mtracewicz
Two days have passed since the last activity. Please take care of this PR.

@github-actions
Copy link

github-actions bot commented Oct 7, 2023

@mtracewicz
Two days have passed since the last activity. Please take care of this PR.

@github-actions
Copy link

github-actions bot commented Oct 9, 2023

@mtracewicz
Two days have passed since the last activity. Please take care of this PR.

@github-actions
Copy link

@mtracewicz
Two days have passed since the last activity. Please take care of this PR.

@github-actions
Copy link

@mtracewicz
Two days have passed since the last activity. Please take care of this PR.

@github-actions
Copy link

@mtracewicz
Two days have passed since the last activity. Please take care of this PR.

@github-actions
Copy link

@mtracewicz
Two days have passed since the last activity. Please take care of this PR.

@github-actions
Copy link

@mtracewicz
Two days have passed since the last activity. Please take care of this PR.

@github-actions
Copy link

@mtracewicz
Two days have passed since the last activity. Please take care of this PR.

@github-actions
Copy link

@mtracewicz
Two days have passed since the last activity. Please take care of this PR.

@github-actions
Copy link

@mtracewicz
Two days have passed since the last activity. Please take care of this PR.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 1, 2023

@mtracewicz
Two days have passed since the last activity. Please take care of this PR.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 4, 2023

@mtracewicz
Two days have passed since the last activity. Please take care of this PR.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 6, 2023

@mtracewicz
Two days have passed since the last activity. Please take care of this PR.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 9, 2023

@mtracewicz
Two days have passed since the last activity. Please take care of this PR.

@github-actions GitHub Actions
Copy link

@mtracewicz
Two days have passed since the last activity. Please take care of this PR.

@github-actions GitHub Actions
Copy link

@mtracewicz
Two days have passed since the last activity. Please take care of this PR.

@github-actions GitHub Actions
Copy link

@mtracewicz
Two days have passed since the last activity. Please take care of this PR.

@github-actions GitHub Actions
Copy link

@mtracewicz
Two days have passed since the last activity. Please take care of this PR.

mtracewicz
mtracewicz reviewed Nov 21, 2023
View reviewed changes
Copy link
Contributor

@mtracewicz mtracewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's ship it!

@Sojusan Sojusan merged commit b8be8e9 into master Nov 21, 2023
5 checks passed
@Sojusan Sojusan deleted the 00058_replace_mui_with_tailwindcss branch October 31, 2024 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtracewicz mtracewicz mtracewicz approved these changes

Assignees

@Sojusan Sojusan

Labels
enhancement Improvement in existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Sojusan @mtracewicz