Fix and improvements for Arduino Uno #10
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The time 1000ms is too long for Arduino Uno since the bootloader stops and starts a sketch after 1000ms pasts after the reset. The 1000ms varies since it is based on watch dog timer of ATmega328. Tested with Arduino Uno and Arduino Duemilanove.
It seems that mCdcAcmInterfaceNum should be the number of counted interface (intfNum) minus 1. Tested serial communication with Arduino Uno. I also tested with Mbed that a sample application can open the mbed serial interface. Not tested serial communication with Mbed.
When I used Physicaloid library with Arduino Uno, an application on an Android dropped some data from Arduino. Here is my changes, o lock the ring-buffer mBuffer when it is read and written, o reduce number of Nofity (onRead()) when small data is received, o use a write buffer to reduce number of USB transaction when small data are written in short period.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Could you check changes? The purpose of changes are
Thank you.