Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Updates gRPC dependencies #453

Merged
merged 1 commit into from
Oct 27, 2023
Merged

Conversation

rafvasq
Copy link
Member

@rafvasq rafvasq commented Oct 26, 2023

Signed-off-by: Rafael Vasquez <[email protected]>
Copy link
Member

@ckadner ckadner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rafvasq

/lgtm

@kserve-oss-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ckadner, rafvasq

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ckadner ckadner merged commit 5ae4ca3 into kserve:main Oct 27, 2023
9 checks passed
@ckadner
Copy link
Member

ckadner commented Oct 27, 2023

@rafvasq -- for future reference, when you removed the indirect requirements from the go.mod file and ran go mod tidy, did you have to specify the compatibility flag?

go mod tidy -compat=1.19

@ckadner ckadner mentioned this pull request Oct 28, 2023
@ckadner ckadner added this to the v0.11.2 milestone Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants