Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: namespace-scoped mode by service_controller #435

Merged
merged 2 commits into from
Sep 28, 2023
Merged

fix: namespace-scoped mode by service_controller #435

merged 2 commits into from
Sep 28, 2023

Conversation

Jooho
Copy link
Contributor

@Jooho Jooho commented Sep 27, 2023 •
edited by ckadner
Loading

Add a ClusterScope condition statement to list namespace that is only allowed for cluster scope.

Resolves #433

@Jooho
Copy link
Contributor Author

Jooho commented Sep 27, 2023 •
edited by ckadner
Loading

Test image:

  • quay.io/jooholee/modelmesh-controller:v0.11.1

With the test image, FVT test passed locally.

Test Steps:

git clone [email protected]:kserve/modelmesh-serving.git
cd modelmesh-serving

minikube start --kubernetes-version=1.26.1 --memory=30G --cpus=8  --disk-size=100g
kubectl create ns modelmesh-serving

CONTROLLERNAMESPACE=modelmesh-serving NAMESPACE=modelmesh-serving MODELMESH_SERVING_IMAGE=quay.io/jooholee/modelmesh-controller:v0.11.1 NAMESPACE_SCOPE_MODE=true make deploy-release-fvt

NAMESPACE=modelmesh-serving CONTROLLERNAMESPACE=modelmesh-serving NAMESPACESCOPEMODE=true make fvt

It will fail until the required images are downloaded. but it will pass all fvt tests eventually.

@ckadner fyi

@Jooho
Copy link
Contributor Author

Jooho commented Sep 27, 2023

/retest

1 similar comment
@Jooho
Copy link
Contributor Author

Jooho commented Sep 27, 2023

/retest

@Jooho
Copy link
Contributor Author

Jooho commented Sep 27, 2023

@ckadner FVT test passed on local minikube. I think it should work with gitaction eventually. could you please trigger the fvt test? I think I can not retrigger the gitaction.

@Jooho Jooho self-assigned this Sep 27, 2023
@Jooho Jooho added the bug Something isn't working label Sep 27, 2023
ckadner
ckadner reviewed Sep 27, 2023
View reviewed changes
Copy link
Member

@ckadner ckadner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Jooho for providing a fix quickly!

A few questions:

controllers/service_controller.go Outdated Show resolved Hide resolved
controllers/service_controller.go Outdated Show resolved Hide resolved
ckadner
ckadner approved these changes Sep 28, 2023
View reviewed changes
Copy link
Member

@ckadner ckadner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Jooho -- this looks good now.

/lgtm

@kserve kserve deleted a comment from kserve-oss-bot Sep 28, 2023
@ckadner
Copy link
Member

ckadner commented Sep 28, 2023

/lgtm

@ckadner
Copy link
Member

ckadner commented Sep 28, 2023

/approve

@kserve-oss-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ckadner, Jooho

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ckadner ckadner merged commit 28ef41b into kserve:main Sep 28, 2023
5 checks passed
@ckadner ckadner removed their assignment Oct 2, 2023
@ckadner ckadner added this to the v0.11.1 milestone Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ckadner ckadner ckadner approved these changes

Assignees

@Jooho Jooho

Labels
approved bug Something isn't working lgtm
Projects
None yet
Milestone
v0.11.1
Development

Successfully merging this pull request may close these issues.

Quickstart broken: modelmesh-serving svc not created in --namespace-scope-mode, ISVCs never get to READY state
3 participants
@Jooho @ckadner @kserve-oss-bot