fix: Update delete.sh to support self-sign-certs #400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafvasq
changed the title
Jooho
force-pushed
the
fix_delete_script
branch
2 times, most recently
from
f6a615c
to
e75d39c
Compare
ckadner
force-pushed
the
fix_delete_script
branch
from
4cc1ae5
to
e3c6f56
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ckadner, Jooho The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: jooho <[email protected]>
ckadner
force-pushed
the
fix_delete_script
branch
from
e3c6f56
to
a391f68
Compare
|
New changes are detected. LGTM label has been removed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This fix #399
Modifications
Add a logic to check if there is a certificate object to generate for webhook or not. If not, it excludes cert-manager objects from manifests when it tries to delete
modelmesh-servingobjectsResult
delete.shalways works to deletemodelmesh-servingobjects.