Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lowercaseit #196

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Conversation

austin-carnahan
Copy link

No description provided.

Copy link

@b-sai b-sai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like how the script runs without using for loops, makes it readable and clear. However, more test cases are not included as per directions on canvas. Another minor point is that the lowercasing for ga is supposed to work for any variant of ga. Ditto for all other languages. But otherwise great stuff!

S23/austin-carnahan/to_lower.py Show resolved Hide resolved
S23/austin-carnahan/to_lower.py Show resolved Hide resolved
S23/austin-carnahan/to_lower.py Outdated Show resolved Hide resolved
@austin-carnahan
Copy link
Author

I like how the script runs without using for loops, makes it readable and clear. However, more test cases are not included as per directions on canvas. Another minor point is that the lowercasing for ga is supposed to work for any variant of ga. Ditto for all other languages. But otherwise great stuff!

@austin-carnahan
Copy link
Author

Thanks for the review! I fixed the parts of the code that were missing use cases - especially the Irish languages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants