-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lowercaseit #196
base: master
Are you sure you want to change the base?
Lowercaseit #196
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like how the script runs without using for loops, makes it readable and clear. However, more test cases are not included as per directions on canvas. Another minor point is that the lowercasing for ga is supposed to work for any variant of ga. Ditto for all other languages. But otherwise great stuff!
|
Thanks for the review! I fixed the parts of the code that were missing use cases - especially the Irish languages. |
No description provided.