Code to Change Words to LowerCase #188

mepripri · 2023-02-16T01:33:00Z

No description provided.

Tanvipatel23 · 2023-02-16T06:27:58Z

new Locale(language)
new Locale(language, country)
new Locale(language, country, variant)

class JavaCharactertoLowerCaseExample1 {
public static void main(String[] args) {

	String s2 = Normalizer.normalize(s, Normalizer.Form.NFD);
		return s2.replaceAll("(?s)\\p{InCombiningDiacriticalMarks}", "");

 char ch1, ch2, ch3, ch4;    
  ch1 = 'TANVI';  
  ch2 = 'PATEL';  
    
  ch3 = Character.toLowerCase(ch1);  
  ch4 = Character.toLowerCase(ch2);  
  String str1 = "The lowercase for the first character '" + ch1 + "' is given as: " + ch3;  
  String str2 = "The lowercase for the second character '" + ch2 + "' is given as: " + ch4;  

  System.out.println( str1 );  
  System.out.println( str2 );  
  }

}

String myString="YAŞAT Patel";
Locale trlocale= new Locale("tr-TR");
Locale enLocale = new Locale("en_US");

Log.v("mainlist", "en source: " +myString.toLowerCase(enLocale));
Log.v("mainlist", "tr source: " +myString.toLowerCase(trlocale));

thofstrand · 2023-02-16T18:53:31Z

S23/mepripri/ToLowerCase.py

@@ -0,0 +1,49 @@
+import csv
+
+def splitLang(l):


This function is great for getting the first part of the language input, but we should make l a little more descriptive in terms of the variable name.

Sure, i will work on the variable name.

thofstrand · 2023-02-16T18:56:07Z

S23/mepripri/ToLowerCase.py

+    lang=splitLang(lang)
+    if lang=='tr' or lang=='az':
+        for i in s:
+            if ord(i)==73:


While this may work, I think the use of hard coded numbers is not ideal. Maybe if the function merely searches for 'I' instead of using ord() that would be a little clearer.

Yes, that also perfect that will be a direct search.

thofstrand · 2023-02-16T19:00:13Z

S23/mepripri/ToLowerCase.py

+            str+=chr(962)
+        else:
+            str=str+s.lower()
+    elif lang=='zh' or lang=='th' or lang=='ja' or lang=='en':


We don't need to specify these four languages, as anything else would be just lower cased. So this could just be an else:

But, i also have a non-language condition there. To solve this I can add that condition in elif and make the rest as else. This will be more better.

thofstrand · 2023-02-16T19:00:46Z

S23/mepripri/ToLowerCase.py

+            str=str+s.lower()
+    elif lang=='zh' or lang=='th' or lang=='ja' or lang=='en':
+        str+=s.lower()
+    else:


We don't need this as any other language is just lower cased.

This is similar to the above one I guess

thofstrand · 2023-02-16T19:04:19Z

S23/mepripri/ToLowerCase.py

+                    first=1
+                else:
+                    str+=s[i].lower()
+            elif i==1 and first==1:


I'm not sure what the elif at line 28 is doing. This may be omitted as it doesn't appear to do anything as of this moment.

This elif condition is actually working as a flag. I will try to look into the code again, if this can be avoided.

thofstrand · 2023-02-16T19:06:52Z

S23/mepripri/tests.tsv

@@ -1,18 +1,29 @@
 HELLO	en	hello
 WORLD	en-US	world
+WORLD	eng-US	Invalid Language


eng would likely produce an invalid language type, but it could also just be lower cased since any other language that is not of the ones specified is just lowered.

This is added because this doesn't fit in the language requirement. If any language is greater than or less than 2 letters will be an invalid language.

thofstrand

Overall this code looks good and you added a decent number of test cases. There is room for improvement in terms of readability and some unnecessary lines. Well done!

mepripri · 2023-02-17T21:22:16Z

I have made the changes to the code. @thofstrand, Can you please review them again

kscanne · 2023-02-23T01:18:07Z

S23/mepripri/ToLowerCase.py

+import csv
+
+def splitLang(lang):
+    lang=lang.split('-')


This works, but I don't really like the change of type here from str to list.

kscanne · 2023-02-23T01:18:36Z

S23/mepripri/ToLowerCase.py

+    if lang=='tr' or lang=='az':
+        for i in s:
+            if i=='I':
+                str+=chr(305)


Magic number.

kscanne · 2023-02-23T01:19:30Z

S23/mepripri/ToLowerCase.py

+                str+=i.lower()
+    elif lang=='ga':
+        if (s[0]=='n' or s[0]=='t') and s[1] in ['A','E','I','O','U','Á','É','Í','Ó','Ú']:
+            str+=s[0].lower()+'-'+s[1:].lower()


s[0] already lowercase here?

kscanne · 2023-02-23T01:19:45Z

S23/mepripri/ToLowerCase.py

+        else:
+            str+=s.lower()
+    elif lang=='el':
+        if ord(s[-1])==931:


Magic numbers — unreadable.

kscanne · 2023-02-23T01:20:13Z

S23/mepripri/ToLowerCase.py

+            str+=chr(962)
+        else:
+            str=str+s.lower()
+    elif len(lang)!=2:


Check out the BCP-47 spec. Language codes can have 2 or 3 letters.

kscanne · 2023-02-23T01:20:27Z

S23/mepripri/ToLowerCase.py

+        else:
+            str=str+s.lower()
+    elif len(lang)!=2:
+        str+='Invalid Language'


You should raise an exception here, not return an error string.

Code to Change Words to LowerCase

6e96ebe

thofstrand reviewed Feb 16, 2023

View reviewed changes

Changes Made

53ed852

mepripri requested a review from thofstrand February 17, 2023 21:21

kscanne reviewed Feb 23, 2023

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Code to Change Words to LowerCase #188

Code to Change Words to LowerCase #188

mepripri commented Feb 16, 2023

Tanvipatel23 commented Feb 16, 2023

thofstrand Feb 16, 2023

mepripri Feb 17, 2023

thofstrand Feb 16, 2023

mepripri Feb 17, 2023

thofstrand Feb 16, 2023 •

edited

Loading

mepripri Feb 17, 2023

thofstrand Feb 16, 2023

mepripri Feb 17, 2023

thofstrand Feb 16, 2023

mepripri Feb 17, 2023

thofstrand Feb 16, 2023

mepripri Feb 17, 2023

thofstrand left a comment

mepripri commented Feb 17, 2023

kscanne Feb 23, 2023

kscanne Feb 23, 2023

kscanne Feb 23, 2023

kscanne Feb 23, 2023

kscanne Feb 23, 2023

kscanne Feb 23, 2023

Code to Change Words to LowerCase #188

Are you sure you want to change the base?

Code to Change Words to LowerCase #188

Conversation

mepripri commented Feb 16, 2023

Tanvipatel23 commented Feb 16, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

thofstrand Feb 16, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

thofstrand left a comment

Choose a reason for hiding this comment

mepripri commented Feb 17, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

thofstrand Feb 16, 2023 •

edited

Loading