-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update tdmpc into kscale sim module. #72
base: master
Are you sure you want to change the base?
Conversation
Do you have some results of standing? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good - could you run make format + make static-checks to make sure that this pr passes the status checks?
I see! What is the most time consuming step in the pipeline? |
horizon update. This line makes the training process so slow. |
Horizon is only 5 and mlp is tiny. I don't understand why would it be that slow? |
The planning step that collects samples from interactions with the environment (MPC) is pretty slow. The number of iterations that we set for humanoid type task is around ~10-12. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see Makefile for linting and semi building. See https://github.com/kscalelabs/sim/blob/master/CONTRIBUTING.md
sim/train_tdmpc.py
Outdated
if tdmpc_cfg.save_model and episode_idx % tdmpc_cfg.eval_freq_episode == 0: | ||
L.save(agent, f"tdmpc_policy_{int(step // tdmpc_cfg.episode_length) + 1}.pt") | ||
buffer.save(str(work_dir / "buffer.pt")) | ||
# # common_metrics['episode_reward'] = evaluate(env, agent, h1 if L.video is not None else None, tdmpc_cfg.eval_episodes, step, env_step, L.video, tdmpc_cfg.action_repeat) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clean up
No description provided.