Errcheck logger

krzko · Jul 26, 2022 · e9bbd58 · e9bbd58
1 parent 6c23376
commit e9bbd58
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/internal/cli/cli.go b/internal/cli/cli.go
@@ -24,12 +24,12 @@ func initLogger(c *cli.Context) error {
 		cfg = zap.NewProductionConfig()
 	}
 	logger, err = cfg.Build()
-
-	defer logger.Sync()
 	if err != nil {
 		panic(err)
 	}
 
+	defer logger.Sync()
+
 	return err
 }
 

diff --git a/internal/cli/traces.go b/internal/cli/traces.go
@@ -152,7 +152,6 @@ func genTracesCommand() *cli.Command {
 				},
 				Action: func(c *cli.Context) error {
 					var err error
-					defer logger.Sync()
 
 					if c.String("otel-exporter-otlp-endpoint") == "" {
 						return errors.New("'otel-exporter-otlp-endpoint' must be set")