Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: for APPLAUNCHER-6 added k8 annotations to global #10

Merged
merged 5 commits into from
Mar 13, 2024

Conversation

Sinjhin
Copy link
Member

@Sinjhin Sinjhin commented Mar 11, 2024

In this screenshot the first global app, gets put there by metadata annotation and shows an unclickable globe. The next two are favorited. Also adds persistence of favorites via localStorage.
image

Addresses:

@Sinjhin Sinjhin self-assigned this Mar 11, 2024
@Sinjhin Sinjhin requested a review from krumware March 13, 2024 09:27
Copy link
Member

@krumware krumware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re: the docs. The documentation in the main readme should be more of a directory of extensions, since there will be more extensions than just the app launcher. There is additional text already in the app launcher folder that this can be merged into.

Otherwise this looks good. I'm adding some more stories for next features in the board.

@Sinjhin
Copy link
Member Author

Sinjhin commented Mar 13, 2024

@krumware Sounds good. I am actually going to just remove the documentation in the README I added in that case until we figure out where and how we want to do that. Actually, I noticed you made a story for that so I will comment it there before I remove it.

@krumware
Copy link
Member

Made the story before I saw the review request. I think your steps are good, maybe just move em to the other readme and it'll start to knock it out

@Sinjhin
Copy link
Member Author

Sinjhin commented Mar 13, 2024

Re: the docs. The documentation in the main readme should be more of a directory of extensions, since there will be more extensions than just the app launcher. There is additional text already in the app launcher folder that this can be merged into.

Otherwise this looks good. I'm adding some more stories for next features in the board.

Addressed by: 2568eba and 932eacd

@Sinjhin Sinjhin merged commit e1e7960 into main Mar 13, 2024
2 checks passed
@Sinjhin Sinjhin deleted the feat/APPLAUNCHER-6__k8_annotation branch March 13, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants