This repository has been archived by the owner on Mar 22, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A problem my server ran into is that autosaving the chests every 10 minutes paused the server for about 15 seconds each time, so I decided to try to make the saving async. I'm not sure I did this correctly without causing memory leaks and other stuff that scared me in the first place, but the lag seems to be gone.
I also added a value in the config for toggling async, but i'm pretty sure that it would be always set to false for people that don't have the new configuration file.
I'm making the pull request on the chance that you might be interested in this. If you are, you probably have to fix the configuration to use true by default. i didn't want to change the code too drastically, i just added in a class for async saving.