#7714 ignore query options from commented out queries #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add offset based realtime consumption status checker * Applied PR suggestions * One log line when consumption catches up * Return numConsumingSegmentsNotCaughtUp * Also add num of outstanding segments to timeout scenario
* First cut at fixing up Hadoop batch segment generation job * Sync with upstream * Revert to previous behavior with pre-Java 9 JREs
Unify the logic of using multiple threads to process segments within the combine operators - Make group-by combine operators follow the numThreads limit so that we can control it's thread usage - Extract common logic in combine operators and simplify the actual implementation NOTE: This PR doesn't limit the thread usage for group-by combine operator to keep the existing behavior, but only make it possible
…onnection (apache#7470) Co-authored-by: Jack Li(Analytics Engineering) <[email protected]>
Co-authored-by: Jack Li(Analytics Engineering) <[email protected]>
…rtToRawIndex) tasks: (apache#7427) 1. Add REFRESH_ONLY header for purge and convertToRawIndex tasks, segment upload api will abort the request if the segment does not exist or is deleted before the upload request is completed. 2. Honor segment lineage for convertToRawIndexTaskGenerator
… columns (apache#7454) Introduce new range index implementation which can be enabled by setting "rangeIndexVersion": 2 to "tableIndexConfig". This will result in faster range queries particularly for timestamp and latency columns, and similar or better performance for floating point columns.
* EXPLAIN PLAN code * Revert pom.xml changes. * Fix merge conflict. * Fix merge conflict. * Fix integration tests. * Fix checkstyle error. * Rebuild. * Cleanup. * Fix broker reduce for explain plan queries. * Code review changes. * Fix test cases. * Fix test cases. * Fix checkstyle error. * codereview changes. * codereview changes. * codereview changes. * codereview changes. * codereview changes. * Show TRANSFORM operator in EXPLAIN PLAN output. * Add test case with Transform function in GROUP BY and ORDER BY. * Cleanup. * Fix test cases. * BROKER_SELECT in EXPLAIN PLAN output for queries that get evaluated on Broker only. * Integration test for EXPLAIN PLAN query. * Fix unit test. * Rebuild. * EXPLAIN PLAN output for Broker evaluated queries. * Fix integration test case. * Code review changes. * Code review changes. * Code review changes. * Fix test case. * Code review changes. * Remove getExplainPlanName() function. * Code review changes.
When updating the upsert metadata, if the update (invalidate an old record, and validate a new record) applies to the same segment, make the update atomic to reduce the temporary inconsistency.
…p delay metrics. This handles the corner case that the metric take the segments which are not ready to merge into consideration. (apache#7827)
…f dimension table (apache#7848)
* added logic to handle semicolon in the query * updated the logic to handle semicolon * removed the comment * updated comments * added trim function to sql * updated the logic of semicolon handling in the sql Co-authored-by: Manish Soni <[email protected]>
Pushes JSON path evaluation down to the storage layer (giving direct access to dictionaries and forward index) which avoids various intermediate materialisations of strings, byte arrays and so on. The benefit to users is the potential to avoid a lot of allocation of large byte[] and String once the JsonPath library can accept UTF-8 encoded byte[]. This also creates an SPI to make the evaluation logic pluggable. The same pushdown mechanism could be abstracted to make extensible to regular expressions etc. in the future.
… check (apache#7880) * Add bootstrap mode for PinotServiceManager to avoid glitch for health check * Adding healthcheck with instance id
Adding a framework of GRPCBrokerResponseHandler parallel to the SingleConnectionBrokerRequestHandler This handler handles data streaming back from server and process reduce in a streaming fashion.
kriti-sc
changed the base branch from
master
to
#7714-ignore-query-options-in-commented-out-queries
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Upgrade Notes
Does this PR prevent a zero down-time upgrade? (Assume upgrade order: Controller, Broker, Server, Minion)
backward-incompat, and complete the section below on Release Notes)Does this PR fix a zero-downtime upgrade introduced earlier?
backward-incompat, and complete the section below on Release Notes)Does this PR otherwise need attention when creating release notes? Things to consider:
release-notesand complete the section on Release Notes)Release Notes
Documentation