Don't throw unnecessary when closing cursor

kriszyp · Jan 3, 2024 · df9ee30 · df9ee30
1 parent 9455907
commit df9ee30
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/src/cursor.cpp b/src/cursor.cpp
@@ -51,11 +51,10 @@ CursorWrap::~CursorWrap() {
 }
 
 Value CursorWrap::close(const CallbackInfo& info) {
-	if (!this->cursor) {
-	  return throwError(info.Env(), "cursor.close: Attempt to close a closed cursor!");
+	if (this->cursor) {
+		mdb_cursor_close(this->cursor);
+		this->cursor = nullptr;
 	}
-	mdb_cursor_close(this->cursor);
-	this->cursor = nullptr;
 	return info.Env().Undefined();
 }
 

diff --git a/util/RangeIterable.js b/util/RangeIterable.js
@@ -31,7 +31,9 @@ export class RangeIterable {
 							} else {
 								iteratorResult = iterator.next();
 								if (iteratorResult.then) {
-									if (!async) throw new Error('Can not synchronously iterate with asynchronous values');
+									if (!async) {
+										throw new Error('Can not synchronously iterate with asynchronous values');
+									}
 									return iteratorResult.then(iteratorResult => this.next(iteratorResult), onError);
 								}
 							}